Bugzilla – Attachment 182834 Details for
Bug 40025
Standard ILL requests don't update form when changing type in edit item metadata
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) Yo
Bug-40025-Fix-change-type-for-edit-item-metadata-1.patch (text/plain), 1.92 KB, created by
Pedro Amorim
on 2025-05-29 12:35:02 UTC
(
hide
)
Description:
Bug 40025: Fix change type for edit item metadata 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) Yo
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-05-29 12:35:02 UTC
Size:
1.92 KB
patch
obsolete
>From b2dc4dadf60501cd4b6e476c2eac1760fad295e4 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 29 May 2025 12:34:31 +0000 >Subject: [PATCH] Bug 40025: Fix change type for edit item metadata 1) Enable > ILLModule 2) Create a new ILL request: > <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard > 3) Add a type, a cardnumber '42' and any library. Click 'Make request'. 4) > You should now be on the 'Manage request' page. Click 'Edit item metadata'. > 5) Change the type. Notice the form doesn't update the fields (as it does > when you create a new ILL request). 6) Apply patch. Repeat step 5. Notice the > form now updates the fields as it does when you create a new ILL request. > >--- > .../includes/ill/backends/Standard/shared/shared.js | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/shared.js b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/shared.js >index 46623bc0f7f..0c49b1daa71 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/shared.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/shared.js >@@ -24,10 +24,14 @@ document.addEventListener("DOMContentLoaded", function () { > $(event.target).parent().remove(); > }); > $("#type").change(function () { >- $("#create_form").prepend( >- '<input type="hidden" name="change_type" value="1" />' >- ); >- $("#create_form").submit(); >+ $("#create_form, #standard_edit_form") >+ .first() >+ .submit(function () { >+ $(this).prepend( >+ '<input type="hidden" name="change_type" value="1" />' >+ ); >+ }) >+ .submit(); > }); > $("#standard-fields").on("keyup", ".custom-name", function () { > var val = $(this).val(); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40025
:
182834
|
182835
|
182878
|
183402