Bugzilla – Attachment 182850 Details for
Bug 39955
Report subgroup filter not cleared when changing tabs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39955: Report subgroup filter not cleared when changing tabs
Bug-39955-Report-subgroup-filter-not-cleared-when-.patch (text/plain), 2.01 KB, created by
Emily Lamancusa (emlam)
on 2025-05-29 18:51:11 UTC
(
hide
)
Description:
Bug 39955: Report subgroup filter not cleared when changing tabs
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-05-29 18:51:11 UTC
Size:
2.01 KB
patch
obsolete
>From e57d7969bb1324269838804e60cdf48c952683ff Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 21 May 2025 14:52:21 +0000 >Subject: [PATCH] Bug 39955: Report subgroup filter not cleared when changing > tabs >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch fixes the JS on the saved SQL reports page so that the >subgroup column filter is correctly cleared when the tab changes. The >wrong table column is targeted. > >To test, apply the patch and go to Reports -> Saved SQL reports. > >- If necessary, at least two SQL reports, each with in a different group > and different subgroup. For example: > - sql: SELECT * FROM items LIMIT 10; > - group: Catalog > - subgroup: Statistics > ...and... > - sql: SELECT * FROM borrowers LIMIT 10; > - group: Patrons > - subgroup: Statistics >- From the saved reports page, go to the tab for one of your reports and > filter by subgroup. >- Switch to a different tab containing SQL reports. The reports should > be shown as expected. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: Anneli Ãsterman <anneli.osterman@koha-suomi.fi> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 081cbb05bc..23c48bfe1c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -2481,7 +2481,7 @@ > let table_dt = rtable.DataTable(); > let col4 = table_dt.columns(4); > col4.search("").visible(true); >- let col5 = table_dt.columns(4); >+ let col5 = table_dt.columns(5); > col5.search("").visible(true); > > var g_id = tab.find("a").data("tabname"); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39955
:
182695
|
182715
| 182850