Bugzilla – Attachment 182854 Details for
Bug 39866
Acquisitions statistics fails when filling only the To date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39866: Acquisitions statistics fails when filling only the To date
Bug-39866-Acquisitions-statistics-fails-when-filli.patch (text/plain), 2.04 KB, created by
Marcel de Rooy
on 2025-05-30 09:48:23 UTC
(
hide
)
Description:
Bug 39866: Acquisitions statistics fails when filling only the To date
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-05-30 09:48:23 UTC
Size:
2.04 KB
patch
obsolete
>From 1f3b469156744c87add5f2d1b115113f989bf493 Mon Sep 17 00:00:00 2001 >From: =?utf-8?q?Adolfo=20Rodr=C3=ADguez?= <adolfo.rodriguez@xercode.es> >Date: Fri, 9 May 2025 11:00:22 +0200 >Subject: [PATCH] Bug 39866: Acquisitions statistics fails when filling only > the To date >Content-Type: text/plain; charset=utf-8 > >This patch fixes the exection of the report Acquisitions statistics if you fill only the To date >Test plan: >1 Execute the report Acquisitions statistics filling only To date filter in Placed on or Received on (/cgi-bin/koha/reports/acquisitions_stats.pl) Koha returns an Internal Server Error >2 Apply patch, restart services >3 Repeat step 1, now the report returns the results page as expected > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >[EDIT] Removed superfluous COALESCEs. >--- > reports/acquisitions_stats.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl >index 4457e56f24..7619d442f3 100755 >--- a/reports/acquisitions_stats.pl >+++ b/reports/acquisitions_stats.pl >@@ -310,10 +310,12 @@ sub calculate { > $strsth .= " ORDER BY $line"; > > my $sth = $dbh->prepare($strsth); >- if ( (@linefilter) and ( $linefilter[1] ) ) { >+ if ( (@linefilter) and ( $linefilter[0] && $linefilter[1] ) ) { > $sth->execute( $linefilter[0], $linefilter[1] ); > } elsif ( $linefilter[0] ) { > $sth->execute( $linefilter[0] ); >+ } elsif ( $linefilter[1] ) { >+ $sth->execute( $linefilter[1] ); > } else { > $sth->execute; > } >@@ -364,10 +366,12 @@ sub calculate { > > my $sth2 = $dbh->prepare($strsth2); > >- if ( (@colfilter) and ( $colfilter[1] ) ) { >+ if ( (@colfilter) and ( $colfilter[0] and $colfilter[1] ) ) { > $sth2->execute( $colfilter[0], $colfilter[1] ); > } elsif ( $colfilter[0] ) { > $sth2->execute( $colfilter[0] ); >+ } elsif ( $colfilter[1] ) { >+ $sth2->execute( $colfilter[1] ); > } else { > $sth2->execute; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39866
:
182160
|
182227
| 182854 |
182855