Bugzilla – Attachment 182865 Details for
Bug 40037
Redundant check in `notices_content` hook handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40037: (follow-up) Remove redundancy in `before_send_messages`
Bug-40037-follow-up-Remove-redundancy-in-beforesen.patch (text/plain), 1.19 KB, created by
David Nind
on 2025-05-30 18:20:57 UTC
(
hide
)
Description:
Bug 40037: (follow-up) Remove redundancy in `before_send_messages`
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-05-30 18:20:57 UTC
Size:
1.19 KB
patch
obsolete
>From 7c1abf6341d4bbdf21e009e8aba770c2d31aadf3 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 30 May 2025 11:41:34 -0300 >Subject: [PATCH] Bug 40037: (follow-up) Remove redundancy in > `before_send_messages` > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Letters.pm | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index c90f335f2b..b1ac8db59c 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1058,15 +1058,13 @@ sub SendQueuedMessages { > } > ); > >- if (@plugins) { >- foreach my $plugin (@plugins) { >- try { >- $plugin->before_send_messages($params); >- } catch { >- warn "$_"; >- exit 1 if $params->{exit_on_plugin_failure}; >- }; >- } >+ foreach my $plugin (@plugins) { >+ try { >+ $plugin->before_send_messages($params); >+ } catch { >+ warn "$_"; >+ exit 1 if $params->{exit_on_plugin_failure}; >+ }; > } > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40037
:
182862
|
182863
|
182864
| 182865