Bugzilla – Attachment 182904 Details for
Bug 31642
Control locations for HTML customizations from new table or Authorised values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31642: (QA follow-up) Hide Custom section when it has no children
Bug-31642-QA-follow-up-Hide-Custom-section-when-it.patch (text/plain), 2.28 KB, created by
Marcel de Rooy
on 2025-06-02 11:46:47 UTC
(
hide
)
Description:
Bug 31642: (QA follow-up) Hide Custom section when it has no children
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-06-02 11:46:47 UTC
Size:
2.28 KB
patch
obsolete
>From 352fb4386d70602a5275a3eb7bd95ebac92a3509 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 2 Jun 2025 13:43:03 +0200 >Subject: [PATCH] Bug 31642: (QA follow-up) Hide Custom section when it has no > children >Content-Type: text/plain; charset=utf-8 > >Test plan: >Have no entries under AV category ADD_CONT_HTML_CUSTOM. >Verify that you do not see Custom at the bottom of the Display >location combo when adding a new html block. >Add one AV entry under ADD_CONT_HTML_CUSTOM. >Refresh and make sure that you see the Custom section now. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../en/modules/tools/additional-contents.tt | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index d82c0f1260..d09bcf0b2a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -556,15 +556,17 @@ > [% END %] > </optgroup> > [% SET custom_available_options = AuthorisedValues.Get('ADD_CONT_HTML_CUSTOM') %] >- <optgroup label="Custom"> >- [% FOREACH l IN custom_available_options %] >- [% IF l.authorised_value == location %] >- <option value="[% l.authorised_value | html %]" selected="selected">[% l.authorised_value | html %]</option> >- [% ELSE %] >- <option value="[% l.authorised_value | html %]">[% l.authorised_value | html %]</option> >+ [% IF custom_available_options.size %] >+ <optgroup label="Custom"> >+ [% FOREACH l IN custom_available_options %] >+ [% IF l.authorised_value == location %] >+ <option value="[% l.authorised_value | html %]" selected="selected">[% l.authorised_value | html %]</option> >+ [% ELSE %] >+ <option value="[% l.authorised_value | html %]">[% l.authorised_value | html %]</option> >+ [% END %] > [% END %] >- [% END %] >- </optgroup> >+ </optgroup> >+ [% END %] > [% END %] > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31642
:
178424
|
178425
|
178426
|
179183
|
179184
|
179185
|
179205
| 182904