Bugzilla – Attachment 182918 Details for
Bug 35761
Add an administration editor for FTP and SFTP servers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35761: (follow-up) Add missing import
Bug-35761-follow-up-Add-missing-import.patch (text/plain), 1.07 KB, created by
Matt Blenkinsop
on 2025-06-03 10:56:35 UTC
(
hide
)
Description:
Bug 35761: (follow-up) Add missing import
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2025-06-03 10:56:35 UTC
Size:
1.07 KB
patch
obsolete
>From 65490029a25e3c4606b014bb710a3696e5180f89 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Thu, 29 May 2025 15:17:46 +0100 >Subject: [PATCH] Bug 35761: (follow-up) Add missing import > >There is a missing import for the encode_json method, as well as an unnecessary call to the Koha::Logger class which throws an error >--- > Koha/File/Transport/SFTP.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/Koha/File/Transport/SFTP.pm b/Koha/File/Transport/SFTP.pm >index 73755f22c38..cd3e108097a 100644 >--- a/Koha/File/Transport/SFTP.pm >+++ b/Koha/File/Transport/SFTP.pm >@@ -23,6 +23,7 @@ use File::Spec; > use IO::File; > use Net::SFTP::Foreign; > use Try::Tiny; >+use JSON qw ( encode_json ); > > use base qw(Koha::File::Transport); > >@@ -90,8 +91,6 @@ sub upload_file { > my ( $self, $local_file, $remote_file ) = @_; > my $operation = "upload"; > >- my $logger = Koha::Logger->get_logger(); >- > $self->{connection}->put( $local_file, $remote_file ) or return $self->_abort_operation($operation); > > $self->add_message( >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35761
:
174933
|
174937
|
175030
|
175052
|
175067
|
175166
|
175608
|
175916
|
176429
|
176430
|
177577
|
177578
|
177741
|
177742
|
178552
|
178553
|
178554
|
179249
|
179250
|
179251
| 182918