Bugzilla – Attachment 182938 Details for
Bug 40042
search_indexes.inc may have undefined index var
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40042: Add default value 0 for index var in search_indexes.inc
Bug-40042-Add-default-value-0-for-index-var-in-sea.patch (text/plain), 1.65 KB, created by
Magnus Enger
on 2025-06-04 10:54:36 UTC
(
hide
)
Description:
Bug 40042: Add default value 0 for index var in search_indexes.inc
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2025-06-04 10:54:36 UTC
Size:
1.65 KB
patch
obsolete
>From 4e6f4870acab1954c66607cc22f0139a793a24cc Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 2 Jun 2025 10:00:32 +0200 >Subject: [PATCH] Bug 40042: Add default value 0 for index var in > search_indexes.inc > >In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". >Set 0 has default value. > >Test plan : >1) Enable system preference 'IntranetCatalogSearchPulldown' >2) Go to catalogue advanced search >3) Look HTML source and check you see: > <select class="advsearch" name="idx" id="idx_0"> > <select class="advsearch" name="idx" id="idx_1"> > <select class="advsearch" name="idx" id="idx_2"> >4) In page page toolbar, click 'Search catalog' >5) Click on 'More options' icon >6) Look HTML source of this part and check you see: > <select class="advsearch" name="idx" id="idx_0"> >Without patch you see: > <select class="advsearch" name="idx" id="idx_"> > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >index 8c01af0f49..ea67ed0234 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >@@ -1,4 +1,7 @@ > [% USE Koha %] >+[% UNLESS index %] >+ [% SET index = 0 %] >+[% END %] > [% SET select_id = refiner ? 'refiner_idx_' _ index : 'idx_' _ index %] > <select class="advsearch" name="idx" id="[% select_id | html %]"> > [% IF ms_kw %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40042
:
182896
|
182938
|
183041