Bugzilla – Attachment 182985 Details for
Bug 40079
C4::Scrubber "note" profile should allow for list (ul/ol and li) HTML tags
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40079: Add ul/ol and li to allowed tags in notes profile
Bug-40079-Add-ulol-and-li-to-allowed-tags-in-notes.patch (text/plain), 2.06 KB, created by
Martin Renvoize (ashimema)
on 2025-06-05 10:07:22 UTC
(
hide
)
Description:
Bug 40079: Add ul/ol and li to allowed tags in notes profile
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-06-05 10:07:22 UTC
Size:
2.06 KB
patch
obsolete
>From 1f20255880a9334ccf23b54b866453781b8191e3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 5 Jun 2025 10:29:41 +0100 >Subject: [PATCH] Bug 40079: Add ul/ol and li to allowed tags in notes profile > >This patch add the unordered list, ordered list and list item html tags >to the list of allowed tags in C4::Scrubber. > >Test plan: >1) Add a course reserve and include the following in the public note > field: > <ul> > <li>First item</li> > <li>Second item</li> > </ul> >2) View the course details page and note "First item Second item" all > appears on the same line (the ul and li tags have been stripped) >3) View the course reserves page and note the same issue in the public > notes field of the table display >4) Apply this patch >5) Repeat 2 and 3 and note you now have a bullet pointed list displayed > in both places >6) The display of the note on the details page may look mis-aligned.. > that will be dealt with on it's own bug >--- > C4/Scrubber.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/C4/Scrubber.pm b/C4/Scrubber.pm >index 855524e2b6d..996512417af 100644 >--- a/C4/Scrubber.pm >+++ b/C4/Scrubber.pm >@@ -30,7 +30,7 @@ my %scrubbertypes = ( > default => {}, # place holder, default settings are below as fallbacks in call to constructor > tag => {}, # uses defaults > comment => { allow => [qw( br b i em big small strong )], }, >- note => { allow => [qw[ br b i em big small strong u hr span div p ]] }, >+ note => { allow => [qw[ br b i em big small strong u hr span div p ul li ]] }, > staff => { > default => [ 1 => { '*' => 1 } ], > comment => 1, >@@ -49,7 +49,6 @@ sub new { > rules => exists $settings->{rules} ? $settings->{rules} : [], > default => exists $settings->{default} ? $settings->{default} : [ 0 => { '*' => 0 } ], > comment => exists $settings->{comment} ? $settings->{comment} : 0, >- note => exists $settings->{note} ? $settings->{note} : 0, > process => 0, > ); > return $scrubber; >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40079
:
182985
|
183014