Bugzilla – Attachment 183065 Details for
Bug 39875
ILL - History check fails if unauthenticated request
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39875: (QA follow-up): Correct historycheck ui_context
Bug-39875-QA-follow-up-Correct-historycheck-uicont.patch (text/plain), 1.53 KB, created by
Pedro Amorim
on 2025-06-06 09:47:55 UTC
(
hide
)
Description:
Bug 39875: (QA follow-up): Correct historycheck ui_context
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-06-06 09:47:55 UTC
Size:
1.53 KB
patch
obsolete
>From 6d5d7e20d1ec3e90cfb3e5fa0c3af255ce5cc675 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Fri, 6 Jun 2025 09:44:23 +0000 >Subject: [PATCH] Bug 39875: (QA follow-up): Correct historycheck ui_context > >This ui_context is supposed to be opac, not staff. >For the purposes of these tests, this is not important, as the ui_context is >only needed for the template params and this is testing if the history check >stage is supposed to show or not. >Reckon this was a copy paste without consequences hence missed, but the code >is now semantically more correct. > >prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >--- > t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >index 0bbcf315398..604f270f0fd 100755 >--- a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >+++ b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >@@ -112,7 +112,7 @@ subtest 'show_history_check' => sub { > my $ill_request_with_no_borrowernumber = $builder->build_sample_ill_request( { borrowernumber => undef } ); > > my $new_opac_history_check = >- Koha::ILL::Request::Workflow::HistoryCheck->new( $metadata_with_no_cardnumber, 'staff' ); >+ Koha::ILL::Request::Workflow::HistoryCheck->new( $metadata_with_no_cardnumber, 'opac' ); > > is( > $new_opac_history_check->show_history_check($ill_request_with_no_borrowernumber), >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39875
:
182273
|
182274
|
182291
|
182292
|
182295
|
182296
|
182858
|
182859
|
183051
|
183052
| 183065