Bugzilla – Attachment 183117 Details for
Bug 38899
Allow the Vue toolbar to be sticky
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38899: Move the toolbar out of the form
Bug-38899-Move-the-toolbar-out-of-the-form.patch (text/plain), 3.04 KB, created by
Jonathan Druart
on 2025-06-10 09:31:50 UTC
(
hide
)
Description:
Bug 38899: Move the toolbar out of the form
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-06-10 09:31:50 UTC
Size:
3.04 KB
patch
obsolete
>From 7bf1d9e1bb6c81bed5f6b27dbf9be65903af9fa7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 12 May 2025 09:57:46 +0200 >Subject: [PATCH] Bug 38899: Move the toolbar out of the form > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../vue/components/Vendors/VendorFormAdd.vue | 20 +++++++++---------- > .../integration/Acquisitions/Vendors_spec.ts | 4 ++-- > 2 files changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue >index 970dc3fbb45..55f193e32bf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue >@@ -5,17 +5,17 @@ > {{ $__("Edit vendor #%s").format(vendor.id) }} > </h1> > <h1 v-else>{{ $__("Add vendor") }}</h1> >+ <Toolbar :sticky="true"> >+ <ButtonSubmit :text="$__('Save')" icon="save" /> >+ <ToolbarButton >+ :to="{ name: 'VendorList' }" >+ :title="$__('Cancel')" >+ icon="times" >+ cssClass="btn btn-link" >+ > >+ </ToolbarButton> >+ </Toolbar> > <form @submit="onSubmit($event)" id="add_vendor"> >- <Toolbar :sticky="true"> >- <ButtonSubmit :text="$__('Save')" icon="save" /> >- <ToolbarButton >- :to="{ name: 'VendorList' }" >- :title="$__('Cancel')" >- icon="times" >- cssClass="btn btn-link" >- > >- </ToolbarButton> >- </Toolbar> > <VendorDetails :vendor="vendor" /> > <VendorContacts :vendor="vendor" /> > <VendorInterfaces :vendor="vendor" /> >diff --git a/t/cypress/integration/Acquisitions/Vendors_spec.ts b/t/cypress/integration/Acquisitions/Vendors_spec.ts >index b82e30f071e..29629460142 100644 >--- a/t/cypress/integration/Acquisitions/Vendors_spec.ts >+++ b/t/cypress/integration/Acquisitions/Vendors_spec.ts >@@ -35,7 +35,7 @@ describe("Vendor CRUD operations", () => { > // Click the button in the toolbar > cy.visit("/cgi-bin/koha/acquisition/vendors"); > cy.contains("New vendor").click(); >- cy.get("#vendor_add h1").contains("Add vendor"); >+ cy.get("h1").contains("Add vendor"); > > // Fill in the form for normal attributes > cy.get("#vendor_add").contains("Submit").click(); >@@ -140,7 +140,7 @@ describe("Vendor CRUD operations", () => { > cy.get("#vendors_list table tbody tr:first").contains("Edit").click(); > cy.wait("@get-vendor"); > cy.wait(500); // Cypress is too fast! Vue hasn't populated the form yet! >- cy.get("#vendor_add h1").contains("Edit vendor"); >+ cy.get("h1").contains("Edit vendor"); > > // Form has been correctly filled in > cy.get("#vendor_name").should("have.value", vendor.name); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38899
:
176545
|
176546
|
181822
|
181823
|
181851
|
181852
|
181965
|
182151
|
182249
|
182250
|
182255
|
182449
|
182580
|
182646
|
182973
|
182974
|
182975
|
182976
|
182977
|
182978
|
182979
|
182980
|
183114
|
183115
|
183116
| 183117 |
183118
|
183119
|
183120
|
183121