Bugzilla – Attachment 183213 Details for
Bug 39592
requestspecific table on reserve/request.pl should be column configurable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39592: Make requestspecific table into a kohaTable
Bug-39592-Make-requestspecific-table-into-a-kohaTa.patch (text/plain), 5.56 KB, created by
Eric Garcia
on 2025-06-12 16:57:17 UTC
(
hide
)
Description:
Bug 39592: Make requestspecific table into a kohaTable
Filename:
MIME Type:
Creator:
Eric Garcia
Created:
2025-06-12 16:57:17 UTC
Size:
5.56 KB
patch
obsolete
>From 33e5d7de9e6fec375395e606bf396aaca0330948 Mon Sep 17 00:00:00 2001 >From: Eric Garcia <cubingguy714@gmail.com> >Date: Thu, 12 Jun 2025 16:44:52 +0000 >Subject: [PATCH] Bug 39592: Make requestspecific table into a kohaTable > >Test plan: >1. Apply patch, restart_all >2. Search the catalog, click place hold and enter a patron >3. Notice the table under "Hold a specific item" can now be configured. >4. Click configure and select any option for default sort order. >5. Go back to the table and notice it is sorted by the option you chose. > >System preferences: >6. Change item-level_itypes to bibliographic record and enable EnableItemGroupHolds, save. >7. Go back to the table and confirm the columns appear. >--- > admin/columns_settings.yml | 29 ++++++++++++++++ > .../prog/en/modules/reserve/request.tt | 33 ++++++++++--------- > 2 files changed, 47 insertions(+), 15 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index f482000815..6f53c99749 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -2237,6 +2237,35 @@ modules: > - > columnname: booking_dates > >+ requests: >+ requestspecific_table: >+ default_sort_order: 1 >+ columns: >+ - >+ columnname: hold >+ - >+ columnname: allowed_pickup_locations >+ - >+ columnname: item_type >+ - >+ columnname: barcode >+ - >+ columnname: item_group >+ - >+ columnname: home_library >+ - >+ columnname: last_location >+ - >+ columnname: collection >+ - >+ columnname: call_number >+ - >+ columnname: copy_number >+ - >+ columnname: volume_number >+ - >+ columnname: information >+ > opac: > biblio-detail: > holdingst: >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 1a949d3c4b..93b1377561 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -813,26 +813,26 @@ > <table id="requestspecific"> > <thead> > <tr> >- <th>Hold</th> >- <th>Allowed pickup locations</th> >+ <th id="hold" data-colname="hold">Hold</th> >+ <th id="allowed_pickup_locations" data-colname="allowed_pickup_locations">Allowed pickup locations</th> > [% IF Koha.Preference('item-level_itypes') %] >- <th>Item type</th> >+ <th id="item_type" data-colname="item_type">Item type</th> > [% END %] >- <th>Barcode</th> >+ <th id="barcode" data-colname="barcode">Barcode</th> > [% IF Koha.Preference('EnableItemGroupHolds') && biblio_info.object.item_groups.count %] >- <th>Item group</th> >+ <th id="item_group" data-colname="item_group">Item group</th> > [% END %] >- <th>Home library</th> >- <th>Last location</th> >+ <th id="home_library" data-colname="home_library">Home library</th> >+ <th id="last_location" data-colname="last_location">Last location</th> > [% IF itemdata_ccode %] >- <th>Collection</th> >+ <th id="collection" data-colname="collection">Collection</th> > [% END %] >- <th>Call number</th> >- <th>Copy number</th> >+ <th id="call_number" data-colname="call_number">Call number</th> >+ <th id="copy_number" data-colname="copy_number">Copy number</th> > [% IF itemdata_enumchron %] >- <th>Vol no.</th> >+ <th id="volume_number" data-colname="volume_number">Vol no.</th> > [% END %] >- <th>Information</th> >+ <th id="information" data-colname="information">Information</th> > </tr> > </thead> > <tbody> >@@ -1509,9 +1509,12 @@ > }); > [% END %] > >- var my_table = $("#requestspecific").kohaTable({ >- paging: false, >- dom: '<"top pager"ilf>t', >+ $(document).ready(function () { >+ requestspecific_table_settings = [% TablesSettings.GetTableSettings( 'circ', 'requests', 'requestspecific_table', 'json' ) | $raw %]; >+ $("#requestspecific").kohaTable({ >+ "bPaginate":false, >+ "bKohaColumnsUseNames": true, >+ }, requestspecific_table_settings); > }); > > $("#club-request-form").on("submit", function() { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39592
:
183213
|
183214
|
183220