Bugzilla – Attachment 183223 Details for
Bug 39223
The OPAC browse search (opac-browse.pl) is broken since 24.11
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39223: Fix the OPAC browse search (opac-browse.pl)
Bug-39223-Fix-the-OPAC-browse-search-opac-browsepl.patch (text/plain), 3.17 KB, created by
David Nind
on 2025-06-13 06:21:03 UTC
(
hide
)
Description:
Bug 39223: Fix the OPAC browse search (opac-browse.pl)
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-06-13 06:21:03 UTC
Size:
3.17 KB
patch
obsolete
>From 2a3a3f0ad9e3f3dcd785564aaf579e127c2bffa4 Mon Sep 17 00:00:00 2001 >From: Alexander Blanchard <alexander.blanchard@openfifth.co.uk> >Date: Tue, 10 Jun 2025 08:27:40 +0000 >Subject: [PATCH] Bug 39223: Fix the OPAC browse search (opac-browse.pl) > >This fixes the OPAC browse search feature (OpacBrowseSearch >system preference, Elasticsearch only). Expanding and >collapsing the search results was not working. > >Test plan: >1. Start up KTD using Elasticsearch; ktd --es7 up >2. Enable the OpacBrowseSearch system preference. >3. In the OPAC, click 'Browse search' (one of the > options under the search box). >4. Search for 'a', for the search type use Author, then > click Search. >5. Click on one of the search results - note that it doesn't > expand to show the titles for the author. >6. Apply the patch. >7. Refresh the page and repeat steps 3 to 5. Note that the > author section now expands andd collapses when clicked, > and that the titles for the author are now shown. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/js/browse.js | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt >index 95746f4353..6b33560da5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt >@@ -103,7 +103,7 @@ > <a class="expand-result" href="#" data-bs-toggle="collapse" aria-expanded="false" aria-controls="collapse"> </a> > </div> > <!-- /#heading.card-header --> >- <div id="collapse" class="collapse" aria-labelledby="heading" data-parent="#browse-searchresults"> >+ <div id="collapse" class="collapse" aria-labelledby="heading" data-bs-parent="#browse-searchresults"> > <div class="card-body"> </div> > </div> > <!-- /#collapse.collapse --> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/browse.js b/koha-tmpl/opac-tmpl/bootstrap/js/browse.js >index b1ce79c4bf..cc37b89245 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/browse.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/browse.js >@@ -68,7 +68,7 @@ $(document).ready(function () { > card.find(".card-header") > .attr("id", "heading" + index) > .find("a") >- .attr("data-target", "#collapse" + index) >+ .attr("data-bs-target", "#collapse" + index) > .attr("aria-controls", "collapse" + index) > .text(object.text); > card.find(".collapse") >@@ -96,7 +96,7 @@ $(document).ready(function () { > } > > var link = $(this); >- var target = link.data("target"); >+ var target = link.data("bs-target"); > var term = link.text(); > > var field = $("#browse-searchresults").data("field"); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39223
:
183112
|
183122
|
183123
|
183223
|
183461