Bugzilla – Attachment 183238 Details for
Bug 34776
Patron messaging preferences are lost when an error occurs during new account creation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34776: Remove unneeded if statement
Bug-34776-Remove-unneeded-if-statement.patch (text/plain), 1.32 KB, created by
David Nind
on 2025-06-13 09:24:36 UTC
(
hide
)
Description:
Bug 34776: Remove unneeded if statement
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-06-13 09:24:36 UTC
Size:
1.32 KB
patch
obsolete
>From 4553f9c59ae076aa447ef9aa5df0e4861953d92e Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Thu, 24 Apr 2025 13:45:32 +0300 >Subject: [PATCH] Bug 34776: Remove unneeded if statement > >We don't need to check if $op is add_form after >error, since this value always changes. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: David Nind <david@davidnind.com> >--- > members/memberentry.pl | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 348c90019e..59bffba29e 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -845,11 +845,7 @@ if ( C4::Context->preference('EnhancedMessagingPreferences') ) { > C4::Form::MessagingPreferences::set_form_values( { borrowernumber => $borrowernumber }, $template ); > } > } else { >- if ( $op eq 'add_form' ) { >- C4::Form::MessagingPreferences::restore_form_values( $input, $template ); >- } else { >- C4::Form::MessagingPreferences::restore_form_values( $input, $template ); >- } >+ C4::Form::MessagingPreferences::restore_form_values( $input, $template ); > } > $template->param( SMSSendDriver => C4::Context->preference("SMSSendDriver") ); > $template->param( SMSnumber => $data{'smsalertnumber'} ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34776
:
178702
|
178896
|
180100
|
181389
|
181433
|
181434
|
183221
|
183222
|
183236
|
183237
|
183238
|
183239
|
183573
|
183574
|
183575
|
183576
|
183577
|
183578
|
183579
|
183580