Bugzilla – Attachment 183247 Details for
Bug 39911
Fatal errors from SIP server are not logged
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39911: Remove redundant warn
Bug-39911-Remove-redundant-warn.patch (text/plain), 1.31 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-06-13 18:32:30 UTC
(
hide
)
Description:
Bug 39911: Remove redundant warn
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-06-13 18:32:30 UTC
Size:
1.31 KB
patch
obsolete
>From dd8c571723cb5577c826254e5ddcd849aacfc7fc Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 13 Jun 2025 15:21:12 -0300 >Subject: [PATCH] Bug 39911: Remove redundant warn > >Following the original test plan you notice, `THIS IS A TEST` is printed >twice: > >* In the logs. >* In STDERR for the SIP server. > >The latter is redundant, and also problematic for >`xt/author/pod_coverage.t` which fails the `no warnings` tests because >of that. > >To test: >1. Run: > $ ktd --shell > k$ prove xt/author/pod_coverage.t >=> FAIL: Scary errors, lots of them >2. Apply this patch >3. Repeat 1 >=> SUCCESS: Tests pass! >4. Follow the original bug test plan >=> SUCCESS: There's `THIS IS A TEST` in the logs, which was the author's >goal in the first place. >5. Sign off :-D >6. Visit bug 40144 :-P > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/SIP/Trapper.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/SIP/Trapper.pm b/C4/SIP/Trapper.pm >index ce1be20e977..65cee113412 100644 >--- a/C4/SIP/Trapper.pm >+++ b/C4/SIP/Trapper.pm >@@ -60,7 +60,6 @@ $SIG{__DIE__} = sub { > my $msg = shift; > my $logger = Koha::Logger->get( { interface => 'sip', category => 'STDERR' } ); > $logger->error($msg) if $logger; >- warn $msg; # die doesn't output the message, warn before dying > die $msg; > }; > >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39911
:
182501
|
182502
|
182503
|
182508
|
183078
|
183203
|
183212
| 183247