Bugzilla – Attachment 183284 Details for
Bug 39998
Missing presentation role on layout tables.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39998: Add presentation role to the layout tables.
Bug-39998-Add-presentation-role-to-the-layout-tabl.patch (text/plain), 4.78 KB, created by
Owen Leonard
on 2025-06-16 13:33:21 UTC
(
hide
)
Description:
Bug 39998: Add presentation role to the layout tables.
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-06-16 13:33:21 UTC
Size:
4.78 KB
patch
obsolete
>From ce28d5392c14e76984c8d1d65cc3ce3a8db6b92b Mon Sep 17 00:00:00 2001 >From: nina martinez <nina.martinez@biblibre.com> >Date: Wed, 21 May 2025 17:02:49 +0200 >Subject: [PATCH] Bug 39998: Add presentation role to the layout tables. > >This patch improves the accessibility of the OPAC. It's a trivial patch >to help assistive technologies understand the different tables. > >Test plan: > >Enable the system preferences: OPACShelfBrowser, OPACPrivacy, >ShowComponentRecords. > >1- On the Koha OPAC, Research a record. >2- Inspect the result page HTML and notice that there is a > role='presentation' in the table tag. >3- Choose a record with a Component section and inspect the HTML, there > should be a role='presentation' in the table tag. >4- Open the Browse shelf. Inspect the HTML and notice that there is a > role='presentation' in the table tag of the browse shelf. >5- Log in to a patron account, go to the Your Summary page, and choose > Privacy in the menu. >6- Inspect the HTML of the page and notice that there is a > role='presentation' in the table tag of the 'Immediate deletion'. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 0c812315d85..f96ce899d2b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -10,7 +10,7 @@ > <a style="font-size: 75%;" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]" class="close_shelf">Close shelf browser <span class="sr-only">(Hides shelf browser)</span></a> > </h2> > >- <table class="table"> >+ <table class="table" role="presentation "> > <tr> > <td class="nav-cell" rowspan="2"> > [% IF shelfbrowser_prev_item %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index c761be0ac5e..4459d3c7e4d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -664,7 +664,7 @@ > [% IF ComponentParts && ComponentParts.size %] > [% WRAPPER tab_panel tabname="components" %] > <div class="content_set"> >- <table> >+ <table role="presentation"> > [% FOR PART IN ComponentParts %] > <tr> > <td> [% PART | $raw %] </td> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >index fa3a98378d3..ac38724d421 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >@@ -179,7 +179,7 @@ > <input type="hidden" name="op" value="cud-delete_record" /> > <input type="hidden" name="all" value="1" /> > </form> >- <table class="table table-bordered table-condensed table-striped"> >+ <table class="table table-bordered table-condensed table-striped" role="presentation"> > <tr> > <td colspan="7">Immediately delete my checkout history. This action cannot be undone.</td> > <td colspan="1"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 0ab92b663d9..81b16f878a7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -231,8 +231,8 @@ > <!-- /#floating --> > > <!-- TABLE RESULTS START --> >- <table class="table table-striped"> >- <caption class="sr-only">Results</caption> >+ <table class="table table-striped" role="presentation"> >+ <span class="sr-only">Results</span> > > <!-- Actual Search Results --> > [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39998
:
182801
| 183284