Bugzilla – Attachment 183347 Details for
Bug 40158
SCO receipt doesnt print when SelfCheckReceiptPrompt is on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40158: [alternate] Remove unnecessary timeout check on sco slip print
Bug-40158-alternate-Remove-unnecessary-timeout-che.patch (text/plain), 2.42 KB, created by
Biblibre Sandboxes
on 2025-06-18 19:47:07 UTC
(
hide
)
Description:
Bug 40158: [alternate] Remove unnecessary timeout check on sco slip print
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2025-06-18 19:47:07 UTC
Size:
2.42 KB
patch
obsolete
>From f74ea0751e4cef3d9650d6bd1057c1c0a487225f Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 18 Jun 2025 01:56:41 +0000 >Subject: [PATCH] Bug 40158: [alternate] Remove unnecessary timeout check on > sco slip print > >This change removes an unnecessary/buggy SelfCheckTimeout check when >using SelfCheckReceiptPrompt slip printing. > >To test: >1. Have SelfCheckReceiptPrompt enabled >2. Go to the self checkout module >3. Login and press 'Finish' >4. Click 'Print receipt and end session' >5. The print screen isn't shown and the user is just logged out >6. APPLY PATCH and refresh the page >7. Login and press 'Finish' then click "Print receipt and end session" >8. You should now see a print screen > >Notes: Set SelfCheckTimeout to a small value like 10 to see that >not choosing an option for the SelfCheckReceiptPrompt will mean you're >automatically logged out by the timer. If you do choose "Print receipt and end session", >the original window will redirect to the logout endpoint, but it won't completely load >until after the print screen is actioned - at least in Chrome. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Christopher <cbrannon@cdalibrary.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 2fa0a7925b..2bd2b5fb85 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -513,9 +513,8 @@ > $("#logout_form").on("click", function(e){ > e.preventDefault(e); > [% IF Koha.Preference('SelfCheckReceiptPrompt') %] >- var confirmStart = Date.now(); > confirmModal("", _("Would you like to print a receipt?"), _("Print receipt and end session"), _("End session"), function(result) { >- if ( result && (Date.now() - confirmStart) < [% Koha.Preference('SelfCheckTimeout') | html %] ) { >+ if ( result ) { > var win = window.open("/cgi-bin/koha/sco/printslip.pl?print=qslip"); > location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout'; > } else { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40158
:
183313
|
183314
|
183315
|
183332
| 183347