Bugzilla – Attachment 183409 Details for
Bug 40165
Incomplete logic for controlling display of OPAC language footer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40165: Incomplete logic for controlling display of OPAC language footer
Bug-40165-Incomplete-logic-for-controlling-display.patch (text/plain), 2.19 KB, created by
Roman Dolny
on 2025-06-20 20:50:18 UTC
(
hide
)
Description:
Bug 40165: Incomplete logic for controlling display of OPAC language footer
Filename:
MIME Type:
Creator:
Roman Dolny
Created:
2025-06-20 20:50:18 UTC
Size:
2.19 KB
patch
obsolete
>From 219311406a8ded2863b9c70edc00b6016a87e933 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 18 Jun 2025 16:59:08 +0000 >Subject: [PATCH] Bug 40165: Incomplete logic for controlling display of OPAC > language footer > >This patch adds some additional logic to the template which controls the >appearance of the footer in the OPAC. Some additional checks are >required to make sure an empty footer doesn't display in some >circumstances. > >To test, apply the patch and install at least one additional translation >besides English. > >Check any OPAC page when various combinations of system preferences are >enabled: > >- opaclanguagesdisplay >- OPACLanguages >- OpacLangSelectorMode >- OPACReportProblem >- CookieConsent >- OpacKohaUurl > >In particular, confirm that there is not an empty footer when >opaclanguagesdisplay is enabled but there is only one translation >enabled. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >index 065c89c471..205f9b2375 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >@@ -22,7 +22,7 @@ > </div> <!-- / #wrapper in masthead.inc --> > <!-- prettier-ignore-end --> > >- [% IF ( Koha.Preference('OPACReportProblem') && Koha.Preference('KohaAdminEmailAddress') ) || Koha.Preference( 'CookieConsent' ) || OpacKohaUrl || ( ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'footer') ) %] >+ [% IF ( Koha.Preference('OPACReportProblem') && Koha.Preference('KohaAdminEmailAddress') ) || Koha.Preference( 'CookieConsent' ) || OpacKohaUrl || ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && ( languages_loop ) && ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'footer') ) %] > <footer id="changelanguage" class="navbar navbar-expand navbar-light bg-light noprint"> > <div class="container-fluid"> > <div class="collapse navbar-collapse"> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40165
:
183345
| 183409