Bugzilla – Attachment 183446 Details for
Bug 40129
Always show the "Not finding what you're looking for" links in opac-results.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40129: Always show the "Not finding what you're looking for" links in opac-results.tt
Bug-40129-Always-show-the-Not-finding-what-youre-l.patch (text/plain), 5.08 KB, created by
Marcel de Rooy
on 2025-06-24 12:17:23 UTC
(
hide
)
Description:
Bug 40129: Always show the "Not finding what you're looking for" links in opac-results.tt
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-06-24 12:17:23 UTC
Size:
5.08 KB
patch
obsolete
>From b9e5df25a9e9ee354a1f1971d197f87361fb6b77 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Thu, 12 Jun 2025 10:19:19 +0200 >Subject: [PATCH] Bug 40129: Always show the "Not finding what you're looking > for" links in opac-results.tt >Content-Type: text/plain; charset=utf-8 > >This patch simplifies the logic for displaying the "make a purchase >suggestion" and "interlibrary loan request" links on the OPAC search results page. > >Previously, the visibility of the purchase suggestion link was tied to a >complex set of conditions evaluated in C4/Auth.pm, involving user login status and >permissions. This was unintuitive, as the authorization to make a >suggestion should be handled by the suggestions page itself >(opac-suggestions.pl), I think. > >This patch alters the template (opac-results.tt) to check the >'suggestion' and 'IllModule' system preferences directly. If suggestions are allowed >system-wide or the master switch for the 'IllModule' is on, the links will be shown >shown to all patrons, regardless of login status. > >To test: >1. Go to Administration > System Preferences > OPAC. >2. Ensure 'Suggestion' is set to 'Enable'. >3. Log out of the OPAC if previously logged in. >4. Perform a search that won't yield any results and verify > the "Make a purchase suggestion" link appears on the results page. >5. Click the link and verify that you are prompted to log in. >6. Now set the 'AnonSuggestions' system preference to 'Allow'. >7. Make sure that the 'AnonmousPatron' borrowernumber is set to > something other than 0 (is this right, though)? >8. Click the link and verify that you are able to make an anonymous > suggestion. >9. Log in as a patron who is NOT allowed to make suggestions (check their > patron category permissions). >10. Perform a search and verify the link is still visible. >11. Here we then get a 404, this should be handled more gracefully, but > still in opac-suggestions.pl to not make opac-results dependent on > a patron object. Ideas very welcome! >11. Go back to System Preferences and set 'suggestion' to 'Don't allow'. >12. Refresh the OPAC search results page. >13. Verify the "Make a purchase suggestion" link is now hidden for both > anonymous and logged-in users. >14. This confirms the link's visibility is controlled solely by the > 'suggestion' system preference. >15. Now the simpler aspect of 'IllModule', first set everything related > to suggestions back to defaults. Then set 'IllModule' to 'Enable'. >16. Make sure the link to place an "interlibrary loan request" is now > shown for unauthenticated patrons as well. >17. Leave some comments regarding the unsolved issue in 11) or other > problems that you might anticipate through this change. > >I first thought this was trivial, but it is not :_D! > >Signed off by: Esther Melander <esther@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 0ab92b663d..2713c1bf2b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -432,18 +432,14 @@ > [% END # / IF total %] > > [%# Display "Not finding what you're looking for" for suggestion or ILL %] >- [% IF suggestion || ( Koha.Preference( 'ILLModule' ) == 1 && ( loggedinusername || Koha.Preference( 'ILLOpacUnauthenticatedRequest') ) ) %] >+ [% IF Koha.Preference( 'suggestion' ) || Koha.Preference( 'ILLModule' ) %] > <div class="suggestion"> > Not finding what you're looking for? > <ul> >- [% IF suggestion %] >- [% IF Koha.Preference( 'AnonSuggestions' ) == 1 %] >- <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add_form">purchase suggestion</a></li> >- [% ELSIF loggedinusername %] >- <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add_form">purchase suggestion</a></li> >- [% END %] >+ [% IF Koha.Preference( 'suggestion' ) %] >+ <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add_form">purchase suggestion</a></li> > [% END %] >- [% IF Koha.Preference( 'ILLModule' ) == 1 && ( loggedinusername || Koha.Preference( 'ILLOpacUnauthenticatedRequest' ) ) %] >+ [% IF Koha.Preference( 'ILLModule' ) %] > [% IF Koha.Preference( 'AutoILLBackendPriority' ) %] > <li>Make an <a href="/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard">interlibrary loan request</a></li> > [% ELSE %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40129
:
183191
| 183446