Bugzilla – Attachment 183529 Details for
Bug 40182
Tracking patron activity with charges
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40182: Update lastseen when adding/modifying charges
Bug-40182-Update-lastseen-when-addingmodifying-cha.patch (text/plain), 3.66 KB, created by
Lari Strand
on 2025-06-26 09:04:51 UTC
(
hide
)
Description:
Bug 40182: Update lastseen when adding/modifying charges
Filename:
MIME Type:
Creator:
Lari Strand
Created:
2025-06-26 09:04:51 UTC
Size:
3.66 KB
patch
obsolete
>From 788d479c4bcfe0cd7765da34833e6665142243e3 Mon Sep 17 00:00:00 2001 >From: lmstrand <lmstrand@gmail.com> >Date: Wed, 25 Jun 2025 14:51:29 +0300 >Subject: [PATCH] Bug 40182: Update lastseen when adding/modifying charges > >--- > .../prog/en/modules/admin/preferences/patrons.pref | 2 ++ > members/mancredit.pl | 2 ++ > members/maninvoice.pl | 2 ++ > members/pay.pl | 6 +++++- > members/paycollect.pl | 6 +++++- > 5 files changed, 16 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >index 424b3eee9b..44a72f0cab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >@@ -110,6 +110,8 @@ Patrons: > check_in: "Checking in an item" > hold: "Placing a hold on an item" > article: "Placing an article request" >+ add_charges: "Adding patron a charge or credit" >+ modify_charges: "Modifying a patron's charge or credit" > - > - pref: AutoApprovePatronProfileSettings > choices: >diff --git a/members/mancredit.pl b/members/mancredit.pl >index b738da0b20..d6431df47f 100755 >--- a/members/mancredit.pl >+++ b/members/mancredit.pl >@@ -97,6 +97,8 @@ if ( $op eq 'cud-add' ) { > cash_register => $cash_register_id > } > ); >+ >+ $patron->update_lastseen('add_charges'); > > my @additional_fields = $line->prepare_cgi_additional_field_values( $input, 'accountlines:credit' ); > if (@additional_fields) { >diff --git a/members/maninvoice.pl b/members/maninvoice.pl >index a3080c51fe..50fc573148 100755 >--- a/members/maninvoice.pl >+++ b/members/maninvoice.pl >@@ -160,6 +160,8 @@ if ( $op eq 'cud-add' ) { > issue_id => $issue_id > } > ); >+ >+ $patron->update_lastseen('add_charges'); > > my @additional_fields = $line->prepare_cgi_additional_field_values( $input, 'accountlines:debit' ); > if (@additional_fields) { >diff --git a/members/pay.pl b/members/pay.pl >index 685df86fb1..5f910f8983 100755 >--- a/members/pay.pl >+++ b/members/pay.pl >@@ -220,6 +220,8 @@ sub writeoff_all { > ); > } > } >+ >+ $patron->update_lastseen('modify_charges'); > > print $input->redirect("/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber"); > return; >@@ -259,6 +261,8 @@ sub apply_credits { > > $patron->account->reconcile_balance(); > >- print $cgi->redirect( "/cgi-bin/koha/members/pay.pl?borrowernumber=" . $patron->borrowernumber ); >+ $patron->update_lastseen('modify_charges'); >+ >+ print $cgi->redirect("/cgi-bin/koha/members/pay.pl?borrowernumber=" . $patron->borrowernumber ); > return; > } >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 6b93d1cff4..d475ae83b7 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -250,7 +250,9 @@ if ( $total_paid and $total_paid ne '0.00' ) { > > $url = "/cgi-bin/koha/members/boraccount.pl"; > } >- >+ >+ $patron->update_lastseen('modify_charges'); >+ > # It's possible renewals took place, parse any renew results > # and pass on > my @renew_result = (); >@@ -287,4 +289,6 @@ $template->param( > [ Koha::AdditionalFields->search( { tablename => 'accountlines:credit' } )->as_list ], > ); > >+ >+ > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40182
: 183529