Bugzilla – Attachment 183550 Details for
Bug 35947
Accounting transactions do not show managing librarian if HidePatronName is set to yes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35947: Show account manager info regardless of HidePatronName pref
Bug-35947-Show-account-manager-info-regardless-of-.patch (text/plain), 3.71 KB, created by
Owen Leonard
on 2025-06-26 15:31:30 UTC
(
hide
)
Description:
Bug 35947: Show account manager info regardless of HidePatronName pref
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-06-26 15:31:30 UTC
Size:
3.71 KB
patch
obsolete
>From 3d5d99ce8f17c8707043584b7aa601fd311459f4 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 25 Jun 2025 16:20:24 +0000 >Subject: [PATCH] Bug 35947: Show account manager info regardless of > HidePatronName pref > >1) Set 'HidePatronName' sys. pref. to 'Don't show' >2) Go to a patron's page >3) Click on the accounting tab >4) Select 'Create manual invoice', put in an amount and press save. >5) In the transactions tab, click on the details of that specifc > transaction >6) Note that in the "Details of debit" table, the Librarian is set to 'a > patron from X branch' >7) Apply patch, restart_all >8) Go to the same transaction, notice that now it says the actual > librarian who was in charge of creating transaction. >9) Click on this name and make sure the link works >10) Go back to accounting section and now make a payment. >11) View details of this transaction and ensure the librarian is present > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../en/modules/members/accountline-details.tt | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >index 44e3adeb001..528c149113f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >@@ -134,7 +134,14 @@ > <td> [% accountline.amountoutstanding | $Price %] </td> > <td> > [% IF accountline.manager_id %] >- [% INCLUDE 'patron-title.inc' patron => accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %] >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% accountline.manager.borrowernumber | uri %]"> >+ [% IF ( accountline.manager.firstname || accountline.manager.surname ) %] >+ [% accountline.manager.firstname | uri %] >+ [% accountline.manager.surname | uri %] >+ [% ELSE %] >+ [% accountline.manager.borrowernumber | uri %] >+ [% END %] >+ </a> > [% END %] > </td> > </tr> >@@ -198,7 +205,14 @@ > <td> [% offset_accountline.amount | $Price %] </td> > <td> > [% IF offset_accountline.manager_id %] >- [% INCLUDE 'patron-title.inc' patron => offset_accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %] >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% offset_accountline.manager.borrowernumber | uri %]"> >+ [% IF ( offset_accountline.manager.firstname || offset_accountline.manager.surname ) %] >+ [% offset_accountline.manager.firstname | uri %] >+ [% offset_accountline.manager.surname | uri %] >+ [% ELSE %] >+ [% offset_accountline.manager.borrowernumber | uri %] >+ [% END %] >+ </a> > [% END %] > </td> > [%- ELSE -%] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35947
:
167673
|
173802
|
183515
|
183516
| 183550