Bugzilla – Attachment 183595 Details for
Bug 40171
ILL Patron Has No Email Address on File message upon "Send Notice To Patron"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40171: Return fail if no transports for patron
Bug-40171-Return-fail-if-no-transports-for-patron.patch (text/plain), 1.57 KB, created by
Pedro Amorim
on 2025-06-27 09:46:04 UTC
(
hide
)
Description:
Bug 40171: Return fail if no transports for patron
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-06-27 09:46:04 UTC
Size:
1.57 KB
patch
obsolete
>From 5962dbdb50cf3b501860407d0bdee2c3bfbfdbde Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Fri, 20 Jun 2025 10:30:17 +0000 >Subject: [PATCH] Bug 40171: Return fail if no transports for patron > >Test plan, k-t-d, don't apply patches yet: >1) Enable ILLModule >2) Create a new ill request at: ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. >4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. >5) Apply patches. Repeat. Notice you get the message: > "The requested notice was NOT queued for delivery by email, SMS". >6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': > - Interlibrary loan ready > - Interlibrary loan unavailable >7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. >--- > Koha/ILL/Request.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 9b151e3924c..4c8453d4dd5 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1776,6 +1776,8 @@ sub send_patron_notice { > ); > my @transports = keys %{ $borrower_preferences->{transports} }; > >+ return { result => { fail => [ 'email', 'sms' ], success => [] } } unless @transports; >+ > # Notice should come from the library where the request was placed, > # not the patrons home library > my $branch = Koha::Libraries->find( $self->branchcode ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40171
:
183383
|
183384
|
183385
|
183593
|
183594
|
183595
|
183627
|
183628
|
183629