Bugzilla – Attachment 183597 Details for
Bug 40022
Release team 25.11
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40022: (follow-up) Use numerical sort
Bug-40022-follow-up-Use-numerical-sort.patch (text/plain), 1.31 KB, created by
Martin Renvoize (ashimema)
on 2025-06-27 11:33:04 UTC
(
hide
)
Description:
Bug 40022: (follow-up) Use numerical sort
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-06-27 11:33:04 UTC
Size:
1.31 KB
patch
obsolete
>From 542208a63c4fa74b6ff850747a4123b39f774c32 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 27 Jun 2025 12:31:10 +0100 >Subject: [PATCH] Bug 40022: (follow-up) Use numerical sort > >We were using template toolkits `sort` which is a string sort and as >such some of our version strings were being sorted incorrectly. > >This patch simply switched to template toolkits `nsort` to force a >numeric sorting which corrects the reverse version sorting for display. > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc >index 2ef59873cea..44ec8a84f90 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc >@@ -88,7 +88,7 @@ > [%- IF p.roles || p.notes -%] > <ul> > [% FOREACH r IN p.roles %] >- [% SET sorted_versions = r.value.sort.reverse %] >+ [% SET sorted_versions = r.value.nsort.reverse %] > <li> > [% INCLUDE role role=r %] > ([% IF sorted_versions.size <= 2 %] >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40022
:
183477
|
183478
|
183479
|
183500
|
183517
|
183518
|
183519
|
183520
|
183521
| 183597