Bugzilla – Attachment 183673 Details for
Bug 40283
Accessibility of the status message in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40283: memberentry page.
Bug-40283-memberentry-page.patch (text/plain), 5.48 KB, created by
Nina Martinez
on 2025-07-01 15:35:11 UTC
(
hide
)
Description:
Bug 40283: memberentry page.
Filename:
MIME Type:
Creator:
Nina Martinez
Created:
2025-07-01 15:35:11 UTC
Size:
5.48 KB
patch
obsolete
>From 426540fabca58b2dc36f4433e763553d0466c8f4 Mon Sep 17 00:00:00 2001 >From: nina martinez <nina.martinez@biblibre.com> >Date: Tue, 10 Jun 2025 17:08:43 +0200 >Subject: [PATCH] Bug 40283: memberentry page. > >Added Alert and status role to the messages tags. > >Test plan: > >1- Enable the system preference: OPACPatronDetails >2- Log in to an adult patron account, go to Personal details >3- Without making any changes, click on "submit update request", the alert message should be : 'No changes were made', Inspect the HTML code, and notice that there is a role='alert' in the message tag. >4- Change your date of birth to today and submit >5- An error message should appear: "The following fields contain invalid information ... Patron's age ... correct and resubmit". Inspect the HTML code and notice that there is a role='alert' in the message tag. >6- Add or change an information, and submit the update. A message should appear: 'Thank you ... ' Inspect the HTML code, and notice that there is a role='status'. >7- Now disable the system preference OPACPatronDetails. The status message should be: 'To make changes to your record, please contact the library'. Inspect the HTML code, and notice that there is a role='status' in the message tag. >8- Now log out, click on create a new account, fill the required fields, and fail the captcha? You should see the error message: 'You typed the wrong ... Please try again.' Inspect the HTML code, and notice that there is a role='alert' in the message tag. >--- > .../en/modules/opac-memberentry-update-submitted.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt >index 488c069e7b..03d15448eb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt >@@ -32,7 +32,7 @@ > </div> > <div class="col-10 order-first order-lg-2"> > <div id="update-submitted" class="maincontent"> >- <div class="alert alert-success"> >+ <div class="alert alert-success" role="status"> > <p><strong>Thank you</strong></p> > [% IF ( Koha.Preference('AutoApprovePatronProfileSettings') ) %] > <p>Your updates have been submitted and your patron account has been modified.</p> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index b6621ad741..f4149bff83 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -77,10 +77,10 @@ > <div id="[% container_id | html %]" class="maincontent"> > [% IF op == 'edit' %] > [% UNLESS OPACPatronDetails %] >- <div class="alert alert-info">To make changes to your record please contact the library.</div> >+ <div class="alert alert-info" role="status">To make changes to your record please contact the library.</div> > [% END %] > [% IF nochanges %] >- <div class="alert alert-error">No changes were made.</div> >+ <div class="alert alert-error" role="alert">No changes were made.</div> > [% END %] > [% END %] > >@@ -89,7 +89,7 @@ > [% END %] > > [% IF invalid_form_fields %] >- <div class="alert alert-error" >+ <div class="alert alert-error" role="alert" > ><strong>The following fields contain invalid information:</strong> > <ul> > [% FOREACH field IN invalid_form_fields %] >@@ -149,7 +149,7 @@ > [% END %] > > [% IF failed_captcha %] >- <div class="alert alert-warning">You typed in the wrong characters in the box before submitting. Please try again.</div> >+ <div class="alert alert-warning" role="alert">You typed in the wrong characters in the box before submitting. Please try again.</div> > [% END %] > > [% IF has_guarantor_flag && !Koha.Preference('OPACPrivacy') && ( Koha.Preference('AllowPatronToSetCheckoutsVisibilityForGuarantor') || Koha.Preference('AllowPatronToSetFinesVisibilityForGuarantor') ) %] >@@ -1175,7 +1175,7 @@ > <h2 class="sr-only">Password</h2> > <fieldset class="rows" id="memberentry_password"> > <legend id="contact_legend">Password</legend> >- <div class="alert alert-info"> >+ <div class="alert alert-info" role="status"> > [% IF patron %] > [% IF ( patron.category.effective_require_strong_password ) %] > <p>Your password must contain at least [% patron.category.effective_min_password_length | html %] characters, including UPPERCASE, lowercase and numbers.</p> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40283
:
183665
|
183666
|
183667
|
183668
|
183669
|
183670
|
183671
|
183672
|
183673
|
183674
|
183683
|
183684
|
183685
|
183686
|
183689
|
183690
|
183691
|
183692
|
183693
|
183694
|
183695
|
183696
|
183697
|
183698
|
183699
|
183700
|
183701