Bugzilla – Attachment 183690 Details for
Bug 40283
Accessibility of the status message in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40283: Placing a hold page.
Bug-40283-Placing-a-hold-page.patch (text/plain), 3.11 KB, created by
Owen Leonard
on 2025-07-02 12:40:41 UTC
(
hide
)
Description:
Bug 40283: Placing a hold page.
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-07-02 12:40:41 UTC
Size:
3.11 KB
patch
obsolete
>From 3b695c02e39e19960ba9bfd8081be2d89efd0b16 Mon Sep 17 00:00:00 2001 >From: nina martinez <nina.martinez@biblibre.com> >Date: Tue, 17 Jun 2025 09:25:55 +0200 >Subject: [PATCH] Bug 40283: Placing a hold page. > >Test plan: > >1. Research a record and choose one, then place a hold on it. Try to > place the hold twice. A message should appear: 'You already have at > least one ... holds must be at the record level.' Inspect the HTML > code and notice that there is a role='alert' in the message tag > >2. Go to the Staff interface, then in Koha administration, click on > 'Circulation and fine rules.' Determine the number of holds allowed. > Log in to a patron account and place holds to reach the limit. Try > to exceed the limit. A message should appear: 'This title cannot be > requested because you have reached the maximum number of holds.' > Inspect the HTML code and notice that there is a role='alert' in the > message tag. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 6a7fb94e4f8..207457ad192 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -164,14 +164,14 @@ > <div class="alert alert-warning">Sorry, you are too young to place a hold for this item.</div> > [% END %] > [% IF ( bibitemloo.already_reserved ) %] >- <div class="alert alert-warning">You have already requested this title.</div> >+ <div class="alert alert-warning" role="alert">You have already requested this title.</div> > [% ELSIF ( bibitemloo.recall ) %] > <div class="alert alert-warning">You have already placed a recall on this title.</div> > [% ELSE %] > [% IF bibitemloo.alreadypossession %] > <div class="alert alert-warning">This title cannot be requested because it's already in your possession.</div> > [% ELSIF bibitemloo.tooManyReserves %] >- <div class="alert alert-warning">This title cannot be requested because you reached the maximum number of holds.</div> >+ <div class="alert alert-warning" role="alert">This title cannot be requested because you reached the maximum number of holds.</div> > [% ELSIF bibitemloo.tooManyHoldsForThisRecord %] > <div class="alert alert-warning">This title cannot be requested because you exceeded max holds per record.</div> > [% ELSIF bibitemloo.tooManyReservesToday %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40283
:
183665
|
183666
|
183667
|
183668
|
183669
|
183670
|
183671
|
183672
|
183673
|
183674
|
183683
|
183684
|
183685
|
183686
|
183689
| 183690 |
183691
|
183692
|
183693
|
183694
|
183695
|
183696
|
183697
|
183698
|
183699
|
183700
|
183701