Bugzilla – Attachment 183757 Details for
Bug 37305
Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37305: (follow-up) Only add control number subfield when defined
Bug-37305-follow-up-Only-add-control-number-subfie.patch (text/plain), 1.15 KB, created by
Martin Renvoize (ashimema)
on 2025-07-03 12:56:43 UTC
(
hide
)
Description:
Bug 37305: (follow-up) Only add control number subfield when defined
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-03 12:56:43 UTC
Size:
1.15 KB
patch
obsolete
>From 9e5aedbf4346e45583e58e66ab866b102feb6aac Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 3 Jul 2025 13:55:09 +0100 >Subject: [PATCH] Bug 37305: (follow-up) Only add control number subfield when > defined > >The previous commit introduced a bug where the control number subfield 'w' >was being added to the MARC field even when undefined, causing test failures. > >This patch adds a condition to only push the control number subfield when >the value is actually defined, matching the pattern used for other subfields >in the method. > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Koha/Biblio.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index 4f0c0bf1f92..45b9b27fc76 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -2013,7 +2013,7 @@ sub generate_marc_host_field { > $w = '(' . $host_field->data() . ')' . $w; > } > >- push @sfd, ( w => $w ); >+ push @sfd, ( w => $w ) if $w; > } > $link_field = MARC::Field->new( 773, '0', ' ', @sfd ); > } elsif ( $marcflavour eq 'UNIMARC' ) { >-- >2.50.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37305
:
169078
|
169079
|
181981
|
181982
|
183540
|
183541
|
183545
|
183546
|
183598
|
183599
|
183755
|
183756
| 183757