Bugzilla – Attachment 183804 Details for
Bug 40306
Use GET in form of value_builder/unimarc_field_4XX.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl
Bug-40306-Use-GET-in-form-of-valuebuilderunimarcfi.patch (text/plain), 4.69 KB, created by
David Nind
on 2025-07-05 01:56:03 UTC
(
hide
)
Description:
Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-07-05 01:56:03 UTC
Size:
4.69 KB
patch
obsolete
>From 809569c7c62729b52060cdb6c5126c4adec64215 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 4 Jul 2025 13:50:45 +0200 >Subject: [PATCH] Bug 40306: Use GET in form of > value_builder/unimarc_field_4XX.pl > >Since CSRF procetion form without CUD action must use GET instead of POST >Fix value_builder/unimarc_field_4XX.pl > >Test plan: >1) Use UNIMARC DB >2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t >3) Create a new biblio record >4) On 461$t click on 'Tag editor' icon >5) Perform a search >6) Click on choose >7) Field 461 is filled > >Signed-off-by: David Nind <david@davidnind.com> >--- > cataloguing/value_builder/unimarc_field_4XX.pl | 4 ++-- > .../cataloguing/value_builder/unimarc_field_4XX.tt | 10 ++++------ > 2 files changed, 6 insertions(+), 8 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl >index 9462daff5e..a65cec5858 100755 >--- a/cataloguing/value_builder/unimarc_field_4XX.pl >+++ b/cataloguing/value_builder/unimarc_field_4XX.pl >@@ -395,8 +395,8 @@ sub plugin { > > my @numbers = (); > >- if ( $total > $resultsperpage ) { >- for ( my $i = 1 ; $i < $total / $resultsperpage + 1 ; $i++ ) { >+ if ( $total_hits > $resultsperpage ) { >+ for ( my $i = 1 ; $i < $total_hits / $resultsperpage + 1 ; $i++ ) { > if ( $i < 16 ) { > my $highlight = 0; > ( $startfrom == ( $i - 1 ) ) && ( $highlight = 1 ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >index db52d39828..691137c73b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >@@ -19,14 +19,12 @@ > [% IF ( Search ) %] > <div id="UNIMARC_Field_4XX_search" class="page-section"> > <h2> Search on </h2> >- <form name="f" method="post" action="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl"> >- [% INCLUDE 'csrf-token.inc' %] >- >+ <form name="f" method="get" action="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl"> > <p> > <input type="hidden" name="plugin_name" value="unimarc_field_4XX.pl" /> > <input type="hidden" name="index" value="[% index | html %]" /> > <input type="hidden" name="result" value="unimarc field 4 [% index | html %]" /> >- <input type="hidden" name="op" value="cud-do_search" /> >+ <input type="hidden" name="op" value="do_search" /> > <label class="label100" for="searchbox">Any word</label> > <input type="text" name="search" id="searchbox" size="35" /><br /> > <label for="itypeloop">Item type:</label> >@@ -59,7 +57,7 @@ > [% ELSE %] > <a > class="resultnumber" >- href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index | html %]&startfrom=[% number.startfrom | html %]&search=[% number.search |uri %]&resultsperpage=[% number.resultsperpage | html %]&type=intranet&op=do_search" >+ href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index | html %]&startfrom=[% number.startfrom | html %]&search=[% search |uri %]&resultsperpage=[% resultsperpage | html %]&type=intranet&op=do_search" > >[% number.number | html %]</a > > > [% END %] >@@ -152,7 +150,7 @@ > [% ELSE %] > <a > class="resultnumber" >- href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index | html %]&startfrom=[% number.startfrom | html %]&search=[% number.search |uri %]&resultsperpage=[% number.resultsperpage | html %]&type=intranet&op=do_search" >+ href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index | html %]&startfrom=[% number.startfrom | html %]&search=[% search |uri %]&resultsperpage=[% resultsperpage | html %]&type=intranet&op=do_search" > > > [% number.number | html %] > </a> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40306
:
183791
| 183804