Bugzilla – Attachment 183845 Details for
Bug 32682
Add permission for viewing patron reading history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32682: Implement reading history permission
Bug-32682-Implement-reading-history-permission.patch (text/plain), 5.28 KB, created by
David Flater
on 2025-07-07 15:46:09 UTC
(
hide
)
Description:
Bug 32682: Implement reading history permission
Filename:
MIME Type:
Creator:
David Flater
Created:
2025-07-07 15:46:09 UTC
Size:
5.28 KB
patch
obsolete
>From 901120213f380055391923120d8c0ecf0049cd63 Mon Sep 17 00:00:00 2001 >From: David Flater <flaterdavid@gmail.com> >Date: Mon, 7 Jul 2025 15:17:54 +0000 >Subject: [PATCH] Bug 32682: Implement reading history permission > >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 10 ++++------ > .../intranet-tmpl/prog/en/includes/members-toolbar.inc | 2 +- > .../intranet-tmpl/prog/en/includes/permissions.inc | 3 +++ > .../prog/en/modules/catalogue/issuehistory.tt | 2 +- > .../prog/en/modules/members/readingrec.tt | 2 +- > 5 files changed, 10 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index 9eb6432712..60e05901e3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -188,12 +188,10 @@ > </li> > [% END %] > [% END %] >- [% IF CAN_user_borrowers_edit_borrowers %] >- [% IF ( intranetreadinghistory ) %] >- <li [% IF readingrecordview %]class="active"[% END %]> >- <a href="/cgi-bin/koha/members/readingrec.pl?borrowernumber=[% patron.borrowernumber | uri %]">Circulation history</a> >- </li> >- [% END %] >+ [% IF CAN_user_borrowers_view_checkout_history %] >+ <li [% IF readingrecordview %]class="active"[% END %]> >+ <a href="/cgi-bin/koha/members/readingrec.pl?borrowernumber=[% patron.borrowernumber | uri %]">Circulation history</a> >+ </li> > [% END %] > [% IF CAN_user_borrowers_edit_borrowers %] > [% IF ( IntranetReadingHistoryHolds ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index c40f34ebce..18c9f348fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -151,7 +151,7 @@ > </li> > [% END %] > [% END %] >- [% IF Koha.Preference('intranetreadinghistory') %] >+ [% IF CAN_user_borrowers_view_checkout_history %] > [% IF ( patron.privacy == 2 ) %] > <li data-bs-toggle="tooltip" data-bs-placement="left" title="Not allowed by patron's privacy settings"> > <a class="dropdown-item disabled" aria-disabled="true" id="exportbarcodes" href="#">Export today's checked in barcodes</a> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index a0e17a2d41..8d59349f16 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -311,6 +311,9 @@ > [%- CASE 'edit_accountline_notes' -%] > <span class="sub_permission edit_notes_subpermission"> Edit accountline notes </span> > <span class="permissioncode">([% name | html %])</span> >+ [%- CASE 'view_checkout_history' -%] >+ <span class="sub_permission view_checkout_history"> Viewing checkout history </span> >+ <span class="permissioncode">([% name | html %])</span> > [%- CASE 'suggestions_manage' -%] > <span class="sub_permission suggestions_manage_subpermission"> Edit purchase suggestions </span> > <span class="permissioncode">([% name | html %])</span> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >index 409f57721b..91e021ff02 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >@@ -41,7 +41,7 @@ > <h1>Checkout history for [% INCLUDE 'biblio-title.inc' %]</h1> > [% IF biblio.author %]<h3>by [% biblio.author | html %]</h3>[% END %] > >- [% SET show_patron_column = Koha.Preference('intranetreadinghistory') AND CAN_user_circulate_circulate_remaining_permissions %] >+ [% SET show_patron_column = CAN_user_borrowers_view_checkout_history) AND CAN_user_circulate_circulate_remaining_permissions %] > > <div class="searchresults page-section"> > [% IF checkouts %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index 9166f33f12..3ddd2144e9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -46,7 +46,7 @@ > [% UNLESS checkouts %][% checkouts = [] %][% END %] > [% UNLESS old_checkouts %][% old_checkouts = [] %][% END %] > [% SET all_checkouts = checkouts.merge(old_checkouts) %] >- [% UNLESS Koha.Preference('intranetreadinghistory') %] >+ [% UNLESS CAN_user_borrowers_view_checkout_history %] > <div class="alert alert-warning">Staff members are not allowed to access patron's checkout history</div> > [% ELSIF is_anonymous %] > <div class="alert alert-warning">This is the anonymous patron, so no circulation history is displayed. To get a list of anonymized loans, please run a report.</div> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32682
:
183844
| 183845 |
183846