Bugzilla – Attachment 183885 Details for
Bug 36947
Sort Elasticsearch/Zebra facets according to configurable locale instead of using Perl's stringwise/bytewise sort
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36947: (QA follow-up) Fix locale-list to show selected values
Bug-36947-QA-follow-up-Fix-locale-list-to-show-sel.patch (text/plain), 1.17 KB, created by
Martin Renvoize (ashimema)
on 2025-07-09 09:28:13 UTC
(
hide
)
Description:
Bug 36947: (QA follow-up) Fix locale-list to show selected values
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-09 09:28:13 UTC
Size:
1.17 KB
patch
obsolete
>From 6f98a7574f34d084a055aa8eba41a65bae93dfe9 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 27 Jun 2025 00:45:27 +0000 >Subject: [PATCH] Bug 36947: (QA follow-up) Fix locale-list to show selected > values > >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > admin/preferences.pl | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index 6b8fe830215..bf67c87e74e 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -126,7 +126,13 @@ sub _get_chunk { > > # Dynamic locale detection for facet sorting using Koha::I18N > require Koha::I18N; >- $chunk->{'CHOICES'} = Koha::I18N::available_locales(); >+ my $locales = Koha::I18N::available_locales(); >+ foreach my $locale (@$locales) { >+ if ( $locale->{value} && $value && $locale->{value} eq $value ) { >+ $locale->{selected} = 1; >+ } >+ } >+ $chunk->{'CHOICES'} = $locales; > $chunk->{'type'} = 'select'; > } elsif ( $options{'choices'} ) { > my $add_blank; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36947
:
167110
|
167125
|
167141
|
167142
|
167143
|
167145
|
167146
|
167188
|
167198
|
167880
|
168488
|
170489
|
183551
|
183552
|
183553
|
183563
|
183564
|
183565
|
183566
|
183567
|
183568
|
183726
|
183727
|
183817
|
183818
|
183881
|
183882
|
183883
|
183884
| 183885 |
183886
|
183887