Bugzilla – Attachment 183887 Details for
Bug 36947
Sort Elasticsearch/Zebra facets according to configurable locale instead of using Perl's stringwise/bytewise sort
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36947: (QA follow-up) Add FacetSortingLocale to Search.t mock preferences
Bug-36947-QA-follow-up-Add-FacetSortingLocale-to-S.patch (text/plain), 1.37 KB, created by
Martin Renvoize (ashimema)
on 2025-07-09 09:28:18 UTC
(
hide
)
Description:
Bug 36947: (QA follow-up) Add FacetSortingLocale to Search.t mock preferences
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-09 09:28:18 UTC
Size:
1.37 KB
patch
obsolete
>From 91c1e31ce2be89fdeb93af60d14de50d15a42364 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 9 Jul 2025 10:23:17 +0100 >Subject: [PATCH] Bug 36947: (QA follow-up) Add FacetSortingLocale to Search.t > mock preferences > >The test was failing because the new FacetSortingLocale system preference >added was not included in the mock preference handler in t/db_dependent/Search.t. >This caused warnings about the unknown preference when the _sort_facets_zebra >function was called. > >This commit adds the FacetSortingLocale preference to the mock, returning >'default' as the value, which matches the expected fallback behavior of >the new unicode collation sorting feature. > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > t/db_dependent/Search.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t >index 9249bca11dc..beaf6cb43ab 100755 >--- a/t/db_dependent/Search.t >+++ b/t/db_dependent/Search.t >@@ -170,6 +170,8 @@ $contextmodule->mock( > return q{}; > } elsif ( $pref eq 'COinSinOPACResults' ) { > return q{}; >+ } elsif ( $pref eq 'FacetSortingLocale' ) { >+ return 'default'; > } else { > warn > "The syspref $pref was requested but I don't know what to say; this indicates that the test requires updating" >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36947
:
167110
|
167125
|
167141
|
167142
|
167143
|
167145
|
167146
|
167188
|
167198
|
167880
|
168488
|
170489
|
183551
|
183552
|
183553
|
183563
|
183564
|
183565
|
183566
|
183567
|
183568
|
183726
|
183727
|
183817
|
183818
|
183881
|
183882
|
183883
|
183884
|
183885
|
183886
| 183887