Bugzilla – Attachment 183889 Details for
Bug 38661
Add warning when deleting import batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38661: (follow-up) Eliminate duplicate ids
Bug-38661-follow-up-Eliminate-duplicate-ids.patch (text/plain), 2.79 KB, created by
Owen Leonard
on 2025-07-09 11:19:22 UTC
(
hide
)
Description:
Bug 38661: (follow-up) Eliminate duplicate ids
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-07-09 11:19:22 UTC
Size:
2.79 KB
patch
obsolete
>From 4fa3ac8e233e0825d4fa1ef2f727827ee0228b75 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 9 Jul 2025 11:13:53 +0000 >Subject: [PATCH] Bug 38661: (follow-up) Eliminate duplicate ids > >The id attribute should be unique on the page, so I'm changing it to a >name attribute and updating the corresonding selector. > >Also, we can eliminate find() here: > >$(this).closest('form').find('input... > >...because $(this) IS the form, so we can optimize a tiny bit by >removing the find(). > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/tools/manage-marc-import.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >index e1c25ae544c..34cc0bd30e6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >@@ -388,7 +388,7 @@ > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="import_batch_id" value="[% batch_lis.import_batch_id | html %]" /> > <input type="hidden" name="op" value="cud-clean-batch" /> >- <input type="hidden" id="import_status" value="[% batch_lis.import_status | html %]" /> >+ <input type="hidden" name="import_status" value="[% batch_lis.import_status | html %]" /> > <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-eraser"></i> Clean</button> > </form> > [% ELSIF ( batch_lis.import_status == 'cleaned' ) %] >@@ -635,12 +635,12 @@ > if ($(this).hasClass("batch_delete")) { > return confirm(_("Are you sure you want to permanently delete this batch?")); > } else { >- if ($(this).closest('form').find('input#import_status').val() === "imported" ) { >+ if ($(this).find("input[name='import_status']").val() === "imported" ) { > return confirm(_("This batch contains imported records. Are you sure you wish to clear all the reservoir records? This cannot be undone.")); > } else { >- return confirm(_("Clear all reservoir records staged in this batch? This cannot be undone.")); >+ return confirm(_("Clear all reservoir records staged in this batch? This cannot be undone.")); >+ } > } >- } > }); > [% IF job_enqueued %] > setTimeout( >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38661
:
183872
|
183888
| 183889