Bugzilla – Attachment 184025 Details for
Bug 40347
Koha/Hold.t generates diag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40347: Remove warnings from Koha/Hold.t
Bug-40347-Remove-warnings-from-KohaHoldt.patch (text/plain), 2.54 KB, created by
Martin Renvoize (ashimema)
on 2025-07-12 10:06:40 UTC
(
hide
)
Description:
Bug 40347: Remove warnings from Koha/Hold.t
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-12 10:06:40 UTC
Size:
2.54 KB
patch
obsolete
>From 0c589989305d97e91d038194ed5b933ab3ebb41d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 11 Jul 2025 10:30:36 +0200 >Subject: [PATCH] Bug 40347: Remove warnings from Koha/Hold.t > >Those diag statements are not really needed > > # Filling a hold when pref enabled should trigger a test > # Filling a hold when pref disabled should not trigger a test > # Updating a hold location when pref disabled should not trigger a test > # Updating a hold location when pref enabled should trigger a test > # Update with no change to pickup location should not trigger a test > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > t/db_dependent/Koha/Hold.t | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Koha/Hold.t b/t/db_dependent/Koha/Hold.t >index 46581eb6e03..55fe078227b 100755 >--- a/t/db_dependent/Koha/Hold.t >+++ b/t/db_dependent/Koha/Hold.t >@@ -367,7 +367,7 @@ subtest 'fill() tests' => sub { > > t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 ); > >- diag("Filling a hold when pref enabled should trigger a test"); >+ # Filling a hold when pref enabled should trigger a test > $builder->build_object( > { > class => 'Koha::Holds', >@@ -379,7 +379,7 @@ subtest 'fill() tests' => sub { > > t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 ); > >- diag("Filling a hold when pref disabled should not trigger a test"); >+ # Filling a hold when pref disabled should not trigger a test > $builder->build_object( > { > class => 'Koha::Holds', >@@ -411,16 +411,17 @@ subtest 'fill() tests' => sub { > )->store; > > # Pref is off, no test triggered >- diag("Updating a hold location when pref disabled should not trigger a test"); >+ # Updating a hold location when pref disabled should not trigger a test > $hold->branchcode( $library_2->branchcode )->store; > > t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 ); >- diag("Updating a hold location when pref enabled should trigger a test"); >+ >+ # Updating a hold location when pref enabled should trigger a test > > # Pref is on, test triggered > $hold->branchcode( $library_1->branchcode )->store; > >- diag("Update with no change to pickup location should not trigger a test"); >+ # Update with no change to pickup location should not trigger a test > $hold->branchcode( $library_1->branchcode )->store; > > }; >-- >2.50.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40347
:
183990
| 184025