Bugzilla – Attachment 184048 Details for
Bug 15516
Allow to place a hold on first available item from a group of titles
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15516: (follow-up) integrate BZ 15516 and BZ 15565
Bug-15516-follow-up-integrate-BZ-15516-and-BZ-1556.patch (text/plain), 3.92 KB, created by
David Cook
on 2025-07-14 07:01:06 UTC
(
hide
)
Description:
Bug 15516: (follow-up) integrate BZ 15516 and BZ 15565
Filename:
MIME Type:
Creator:
David Cook
Created:
2025-07-14 07:01:06 UTC
Size:
3.92 KB
patch
obsolete
>From e3a18c1171e7dfaa6370ce6e534459a3394bb00e Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 14 Jul 2025 06:52:48 +0000 >Subject: [PATCH] Bug 15516: (follow-up) integrate BZ 15516 and BZ 15565 > >This patch makes DisplayAddHoldGroups and DisplayMultiItemHolds >work together, so that you can add multiple items to 1 hold group >from the staff detail page, the OPAC detail page, or the OPAC >search results. > >Note: At this time, you can't add multiple items to a hold group >from the staff search results. This is due to the existing constraints >in request.pl > >Over the last 10 years, in practice most hold groups have been formed >at the OPAC anyway. > >Test plan: >__OPAC search results__ >- Enable both DisplayAddHoldGroups and DisplayMultiItemHolds >- Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 >- Choose "Gairm" and "Continuous delivery" and click "Place hold" >- Checkbox "Treat as hold group" >- Click "Show more options" for each record >- Click "A specific item" for "Continuous delivery" >- Checkbox both specific items for that title >- Press "Confirm hold" >- Note 3 holds are in the hold group >- Cancel all the holds > >__OPAC detail page__ >- Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=134 >- Click "Place hold" >- Checkbox "Treat as hold group" >- Click "Show more options" >- Choose "A specific item" >- Checkbox both items >- Click "Confirm hold" >- Note 2 holds are in the hold group >- Cancel all the holds > >__Staff detail page__ >- Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=134&borrowernumber=51 >- Choose "Hold a specific item" >- Checkbox "Treat as hold group" >- Checkbox both items >- Click "Place hold" >- Note 2 holds are in the hold group >- Cancel all the holds >--- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 8 ++++++++ > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 09fe7106a5..b9d3edab89 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -808,6 +808,14 @@ > [% biblio_info.biblioitem.publicationyear | html %] > </li> > [% END %] >+ >+ [% IF ( Koha.Preference('DisplayAddHoldGroups') && Koha.Preference('DisplayMultiItemHolds') ) %] >+ <li id="hold_group_list_item"> >+ <label for="hold_group">Treat as hold group: </label> >+ <input name="hold_group" id="hold_group" type="checkbox" /> >+ <span class="hint">Place a hold on the next available title from this group</span> >+ </li> >+ [% END %] > </ol> > > <table id="requestspecific"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index b5c5120c23..551c072f6c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -110,7 +110,7 @@ > [% INCLUDE 'csrf-token.inc' %] > <legend class="sr-only">Hold requests</legend> > <input type="hidden" name="op" value="cud-place_reserve" /> >- [% IF ( Koha.Preference('DisplayAddHoldGroups') && ( multi_hold ) ) %] >+ [% IF ( Koha.Preference('DisplayAddHoldGroups') && ( multi_hold || Koha.Preference('DisplayMultiItemHolds') ) ) %] > <div id="hold_group"> > <fieldset class="rows"> > <ul> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15516
:
46392
|
47498
|
47570
|
47961
|
47962
|
47963
|
48097
|
48098
|
48448
|
48449
|
50094
|
50095
|
50096
|
53742
|
53743
|
53744
|
53770
|
53771
|
53772
|
53774
|
53775
|
53776
|
54977
|
55300
|
55304
|
55305
|
55306
|
55307
|
55308
|
55768
|
55769
|
55770
|
55771
|
55772
|
58799
|
58800
|
58801
|
58802
|
58803
|
59314
|
59315
|
59316
|
59317
|
59318
|
69902
|
69903
|
69904
|
69905
|
69906
|
72485
|
72486
|
72487
|
72488
|
72489
|
72491
|
79077
|
79078
|
79080
|
79081
|
79082
|
79083
|
79213
|
79214
|
79215
|
79216
|
79217
|
79218
|
79219
|
79220
|
79221
|
79222
|
81453
|
81454
|
81455
|
81456
|
81457
|
81458
|
81459
|
81460
|
81461
|
81462
|
81463
|
84554
|
84555
|
84556
|
84557
|
84558
|
84559
|
84560
|
84561
|
84562
|
84563
|
84564
|
87828
|
87829
|
87830
|
87831
|
87832
|
87833
|
87834
|
87835
|
87836
|
87837
|
87838
|
88038
|
88039
|
88125
|
88173
|
88174
|
88175
|
88176
|
88177
|
88178
|
88179
|
88180
|
88181
|
88182
|
88183
|
88184
|
88185
|
88186
|
90289
|
90290
|
90291
|
90292
|
90293
|
90294
|
90295
|
90296
|
90297
|
90298
|
90299
|
90300
|
90301
|
90302
|
90303
|
90829
|
90830
|
90831
|
90832
|
90833
|
90834
|
90835
|
90836
|
90837
|
90838
|
90839
|
90840
|
90841
|
90842
|
90843
|
90844
|
92783
|
92784
|
92785
|
92786
|
92787
|
92788
|
92789
|
92790
|
92791
|
92792
|
92793
|
92794
|
92795
|
92796
|
92797
|
92798
|
114513
|
114514
|
114515
|
114516
|
114517
|
114518
|
114585
|
114586
|
114603
|
114624
|
114625
|
114626
|
114627
|
114628
|
114629
|
114630
|
114631
|
114632
|
114633
|
114634
|
114635
|
114636
|
114637
|
114638
|
114639
|
114640
|
114641
|
114642
|
114643
|
114644
|
114645
|
114647
|
114648
|
114649
|
114650
|
114651
|
114652
|
114653
|
114654
|
114655
|
114656
|
114657
|
114658
|
114659
|
117423
|
117424
|
117425
|
117426
|
118281
|
118282
|
118283
|
118284
|
118285
|
118286
|
118350
|
118351
|
118352
|
118353
|
118354
|
118355
|
120368
|
120369
|
120370
|
120371
|
120372
|
120373
|
120574
|
120643
|
120644
|
120645
|
120646
|
120647
|
120648
|
120649
|
120650
|
120651
|
121523
|
121623
|
122097
|
122102
|
122627
|
128189
|
128190
|
128191
|
128192
|
128193
|
128194
|
128195
|
128196
|
128197
|
128198
|
128199
|
128200
|
128201
|
128202
|
128255
|
128256
|
128257
|
128258
|
128259
|
128260
|
128261
|
128262
|
128263
|
128264
|
128265
|
128266
|
128267
|
128268
|
128269
|
128285
|
128286
|
128287
|
128288
|
128289
|
128290
|
128291
|
128292
|
128293
|
128294
|
128295
|
128296
|
128297
|
128298
|
128299
|
138576
|
138577
|
138578
|
138579
|
138580
|
138581
|
138582
|
138583
|
138584
|
138585
|
138586
|
138587
|
138588
|
138589
|
138593
|
138594
|
138595
|
138596
|
138597
|
138738
|
138739
|
138740
|
138741
|
138742
|
138772
|
138868
|
138869
|
162076
|
162077
|
162078
|
162079
|
162080
|
162081
|
162082
|
162083
|
162084
|
183876
|
183877
|
183878
|
183879
|
183880
|
183915
|
184047
|
184048
|
184050
|
184051
|
184052
|
184053
|
184054
|
184055
|
184056
|
184057
|
184058
|
184066
|
184530
|
184534
|
185135
|
185456
|
185457
|
185458
|
185459
|
185460
|
185461
|
185462
|
185463
|
185464
|
185465
|
185466
|
185492
|
185509