Bugzilla – Attachment 184069 Details for
Bug 34671
Collapsing fields in patron form allows saving without mandatory fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34671: Add error message before legend
0003-Bug-34671-Add-error-message-before-legend.patch (text/plain), 1.35 KB, created by
Emmi Takkinen
on 2025-07-15 05:42:56 UTC
(
hide
)
Description:
Bug 34671: Add error message before legend
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2025-07-15 05:42:56 UTC
Size:
1.35 KB
patch
obsolete
>From 8c0fc62ea186fcfa35e638cb7d9049f930c8bec6 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Tue, 15 Jul 2025 08:14:42 +0300 >Subject: [PATCH 3/3] Bug 34671: Add error message before legend > >If error message was added after legend collapsing >fields no longer works as expected. This patch >fixes this. > >To test: >1. Confirm that error message "There are some required >fields..." is displayed above field sets legend. >2. Collapsing field set field works as expected. >--- > koha-tmpl/intranet-tmpl/prog/js/members.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/members.js b/koha-tmpl/intranet-tmpl/prog/js/members.js >index 017191cd5c..274e2ef5a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/members.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/members.js >@@ -369,7 +369,7 @@ $(document).ready(function () { > var fieldset_id = fieldset.attr("id"); > //Add error message only if it doesn't already exist > if(!$("#"+fieldset_id+"-error").length){ >- fieldset.find("legend").after('<span id="'+fieldset_id+'-error" class="required">'+error_msg+'</span>'); >+ fieldset.find("legend").before('<span id="'+fieldset_id+'-error" class="required">'+error_msg+'</span>'); > } > }); > } >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34671
:
155643
|
156145
|
156263
|
156264
|
156453
|
156454
|
158168
|
158299
|
158524
|
158525
|
158526
|
184067
|
184068
|
184069
|
185285