Bugzilla – Attachment 184075 Details for
Bug 40372
api/v1/holds.t generates a warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40372: Remove warning from api/v1/holds.t
Bug-40372-Remove-warning-from-apiv1holdst.patch (text/plain), 1.42 KB, created by
Jonathan Druart
on 2025-07-15 09:06:53 UTC
(
hide
)
Description:
Bug 40372: Remove warning from api/v1/holds.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-15 09:06:53 UTC
Size:
1.42 KB
patch
obsolete
>From 7f00b6369b78fe7991fd7c205dadcb3f53992978 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Jul 2025 11:05:52 +0200 >Subject: [PATCH] Bug 40372: Remove warning from api/v1/holds.t > >t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. > >We do not test the notification here, we can simply ignore the letters >code >--- > t/db_dependent/api/v1/holds.t | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t >index 9f13cb3a4dd..728de95644d 100755 >--- a/t/db_dependent/api/v1/holds.t >+++ b/t/db_dependent/api/v1/holds.t >@@ -17,7 +17,8 @@ > > use Modern::Perl; > >-use Test::More tests => 16; >+use Test::More tests => 17; >+use Test::NoWarnings; > use Test::MockModule; > use Test::Mojo; > use t::lib::TestBuilder; >@@ -199,6 +200,10 @@ subtest "Test endpoints with permission" => sub { > > plan tests => 45; > >+ # Prevent warning 'No reserves HOLD_CANCELLATION letter transported by email' >+ my $mock_letters = Test::MockModule->new('C4::Letters'); >+ $mock_letters->mock( 'GetPreparedLetter', sub { return } ); >+ > $t->get_ok("//$userid_1:$password@/api/v1/holds")->status_is(200)->json_has('/0')->json_has('/1')->json_hasnt('/2'); > > $t->get_ok("//$userid_1:$password@/api/v1/holds?priority=2")->status_is(200) >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40372
:
184075
|
184242