Bugzilla – Attachment 184082 Details for
Bug 40380
Koha/Patrons/Import.t generates warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40380: Remove warnings from Patrons/Import.t - Use of uninitialized value $csvkeycol{"dateexpiry"} in array element
Bug-40380-Remove-warnings-from-PatronsImportt---Us.patch (text/plain), 1.72 KB, created by
Jonathan Druart
on 2025-07-15 11:49:59 UTC
(
hide
)
Description:
Bug 40380: Remove warnings from Patrons/Import.t - Use of uninitialized value $csvkeycol{"dateexpiry"} in array element
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-15 11:49:59 UTC
Size:
1.72 KB
patch
obsolete
>From bfd56b7f8512df9c488bbcc768754014e168aa8f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Jul 2025 13:43:18 +0200 >Subject: [PATCH] Bug 40380: Remove warnings from Patrons/Import.t - Use of > uninitialized value $csvkeycol{"dateexpiry"} in array element > >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$handle_2> line 2. >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$handle_3> line 2. >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$handle_4> line 2. >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$fh> line 2. >--- > Koha/Patrons/Import.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index 50c17e0153f..fa3f05fc3ce 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -307,7 +307,8 @@ LINE: while ( my $borrowerline = <$handle> ) { > next if $col eq 'password' && !$overwrite_passwords; > next if $col eq 'dateexpiry' && $update_dateexpiry; > >- $borrower{$col} = $member->{$col} if $col eq 'dateexpiry' && !$columns[ $csvkeycol{$col} ]; >+ $borrower{$col} = $member->{$col} >+ if $col eq 'dateexpiry' && ( !$csvkeycol{$col} || !$columns[ $csvkeycol{$col} ] ); > > unless ( exists( $csvkeycol{$col} ) || $defaults->{$col} ) { > $borrower{$col} = $member->{$col} if ( $member->{$col} ); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40380
: 184082 |
184083