Bugzilla – Attachment 184083 Details for
Bug 40380
Koha/Patrons/Import.t generates warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40380: Remove warnings from Patrons/Import.t - Argument "" isn't numeric in numeric eq (==)
Bug-40380-Remove-warnings-from-PatronsImportt---Ar.patch (text/plain), 1.92 KB, created by
Jonathan Druart
on 2025-07-15 11:50:01 UTC
(
hide
)
Description:
Bug 40380: Remove warnings from Patrons/Import.t - Argument "" isn't numeric in numeric eq (==)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-15 11:50:01 UTC
Size:
1.92 KB
patch
obsolete
>From 28cfd21fcfa3d65365e0ed128c9bac1b207cb412 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Jul 2025 13:48:43 +0200 >Subject: [PATCH] Bug 40380: Remove warnings from Patrons/Import.t - Argument > "" isn't numeric in numeric eq (==) > >Using perl -MCarp::Always: >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1017, <$handle_1> line 2. >DBIx::Class::Row::_eq_column_values(Koha::Schema::Result::Borrower=HASH(0x57c409b9ec08), "autorenew_checkouts", "", 1) called at /usr/share/perl5/DBIx/Class/Row.pm line 945 >--- > Koha/Patrons/Import.pm | 2 +- > t/db_dependent/Koha/Patrons/Import.t | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index fa3f05fc3ce..f36495d76ac 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -268,7 +268,7 @@ LINE: while ( my $borrowerline = <$handle> ) { > # Remove warning for int datatype that cannot be null > # Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 > for my $field ( >- qw( privacy privacy_guarantor_fines privacy_guarantor_checkouts anonymized login_attempts checkprevcheckout) >+ qw( privacy privacy_guarantor_fines privacy_guarantor_checkouts anonymized login_attempts checkprevcheckout autorenew_checkouts ) > ) > { > delete $borrower{$field} >diff --git a/t/db_dependent/Koha/Patrons/Import.t b/t/db_dependent/Koha/Patrons/Import.t >index 8949574a797..64e5f95a069 100755 >--- a/t/db_dependent/Koha/Patrons/Import.t >+++ b/t/db_dependent/Koha/Patrons/Import.t >@@ -18,7 +18,8 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More tests => 180; >+use Test::More tests => 181; >+use Test::NoWarnings; > use Test::Warn; > use Test::Exception; > use Encode qw( encode_utf8 ); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40380
:
184082
| 184083