Bugzilla – Attachment 184101 Details for
Bug 40173
Reuse http-client from Cypress tests - preparation steps
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40173: Remove Cypress warnings
Bug-40173-Remove-Cypress-warnings.patch (text/plain), 1.68 KB, created by
Matt Blenkinsop
on 2025-07-15 13:38:12 UTC
(
hide
)
Description:
Bug 40173: Remove Cypress warnings
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2025-07-15 13:38:12 UTC
Size:
1.68 KB
patch
obsolete
>From 02fd7da12927dd12badd3ca34a29bc72f53ee86d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 10 Jul 2025 13:51:00 +0200 >Subject: [PATCH] Bug 40173: Remove Cypress warnings > >Cypress Warning: Cypress detected that you returned a promise in a >test, but also invoked one or more cy commands inside of that promise. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >--- > t/cypress/integration/t/api-client.ts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/cypress/integration/t/api-client.ts b/t/cypress/integration/t/api-client.ts >index 7fb60112272..693328a61e4 100644 >--- a/t/cypress/integration/t/api-client.ts >+++ b/t/cypress/integration/t/api-client.ts >@@ -2,9 +2,9 @@ const { APIClient } = require("./../../plugins/dist/api-client.cjs.js"); > > describe("Using APIClient", () => { > let client = APIClient.default; >- it("should 404 for non-existent biblio", async () => { >+ it("should 404 for non-existent biblio", () => { > try { >- await client.koha.get({ >+ client.koha.get({ > endpoint: "/api/v1/public/biblios/99999", > return_response: true, > }); >@@ -15,9 +15,9 @@ describe("Using APIClient", () => { > }); > > describe("Using the api-client plugin", () => { >- it("should 404 for non-existent biblio", async () => { >+ it("should 404 for non-existent biblio", () => { > try { >- await cy.task("apiGet", { >+ cy.task("apiGet", { > endpoint: "/api/v1/public/biblios/99999", > return_response: true, > }); >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40173
:
183354
|
183355
|
183356
|
183920
|
183928
|
183994
|
183995
|
183996
|
183997
|
184098
|
184099
|
184100
|
184101
|
184323
|
184324
|
184325
|
184326