Bugzilla – Attachment 184130 Details for
Bug 40405
systempreferences.value cannot be set to NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40405: Set decreaseLoanHighHolds\* to 0
Bug-40405-Set-decreaseLoanHighHolds-to-0.patch (text/plain), 1.71 KB, created by
Jonathan Druart
on 2025-07-16 10:01:35 UTC
(
hide
)
Description:
Bug 40405: Set decreaseLoanHighHolds\* to 0
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-16 10:01:35 UTC
Size:
1.71 KB
patch
obsolete
>From 37a9311a6e577f7fab6bfcbf5f7c24489a3f9bbd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 16 Jul 2025 11:59:17 +0200 >Subject: [PATCH] Bug 40405: Set decreaseLoanHighHolds\* to 0 > >When reviewing the different sysprefs that had "NULL" as default, I >only found those 2 occurrences that could be problematic. I think we >should default to 0 here. >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index f9cf48a6058..0d9d85765f1 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1456,7 +1456,7 @@ sub checkHighHolds { > $return_data->{outstanding} = $holds->count(); > > my $decreaseLoanHighHoldsControl = C4::Context->preference('decreaseLoanHighHoldsControl'); >- my $decreaseLoanHighHoldsValue = C4::Context->preference('decreaseLoanHighHoldsValue'); >+ my $decreaseLoanHighHoldsValue = C4::Context->preference('decreaseLoanHighHoldsValue') || 0; > my $decreaseLoanHighHoldsIgnoreStatuses = C4::Context->preference('decreaseLoanHighHoldsIgnoreStatuses'); > > my @decreaseLoanHighHoldsIgnoreStatuses = split( /,/, $decreaseLoanHighHoldsIgnoreStatuses ); >@@ -1528,7 +1528,7 @@ sub checkHighHolds { > # overrides decreaseLoanHighHoldsDuration syspref > $duration = $rule; > } else { >- $duration = C4::Context->preference('decreaseLoanHighHoldsDuration'); >+ $duration = C4::Context->preference('decreaseLoanHighHoldsDuration') || 0; > } > my $reduced_datedue = $calendar->addDuration( $issuedate, $duration ); > $reduced_datedue->set_hour( $orig_due->hour ); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40405
:
184129
| 184130 |
184131
|
184205