Bugzilla – Attachment 184133 Details for
Bug 40407
Remove legacy "pre-wrap" versions (was Patron/Borrower_Discharge.t generates warnings)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40407: Remove legacy "pre-wrap" versions
Bug-40407-Remove-legacy-pre-wrap-versions.patch (text/plain), 2.63 KB, created by
Jonathan Druart
on 2025-07-16 10:21:22 UTC
(
hide
)
Description:
Bug 40407: Remove legacy "pre-wrap" versions
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-16 10:21:22 UTC
Size:
2.63 KB
patch
obsolete
>From 0e45e1ce13cd614f3ec7220622caca7067062af2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 16 Jul 2025 12:19:44 +0200 >Subject: [PATCH] Bug 40407: Remove legacy "pre-wrap" versions > >From https://css-tricks.com/snippets/css/make-pre-text-wrap/ > >/* Browser specific (not valid) styles to make preformatted text wrap */ > >pre { > white-space: pre-wrap; /* css-3 */ > white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ > white-space: -pre-wrap; /* Opera 4-6 */ > white-space: -o-pre-wrap; /* Opera 7 */ > word-wrap: break-word; /* Internet Explorer 5.5+ */ >} > >... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. > >Test plan (from bug 921)0: > * place a hold on a title with a very very long title or author > * mark it as "waiting for pickup" by doing a checkin > * go to command line interface, and run > * misc/cronjobs/gather_print_notices.pl /tmp > * misc/cronjobs/printoverdues.sh /tmp > * if your title/author is long enough, it's splitted on 2 lines > with this patch (it is not before this patch) > >It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t >WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. >WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. >WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt | 3 --- > misc/cronjobs/overdue_notices.pl | 3 --- > 2 files changed, 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt >index d7ccd43ea54..44a6637d26a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt >@@ -14,9 +14,6 @@ > .message { page-break-after: always } > pre { font-family: monospace } > pre {white-space: pre-wrap;} >- pre {white-space: -moz-pre-wrap;} >- pre {white-space: -o-pre-wrap;} >- pre {word-wrap: break-work;} > --> > </style> > <!-- prettier-ignore-end --> >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 298e1ed414a..f0ca534e5d6 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -1034,9 +1034,6 @@ sub _get_html_start { > <style type='text/css'> > pre {page-break-after: always;} > pre {white-space: pre-wrap;} >-pre {white-space: -moz-pre-wrap;} >-pre {white-space: -o-pre-wrap;} >-pre {word-wrap: break-work;} > </style> > </head> > <body>"; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40407
: 184133