Bugzilla – Attachment 184148 Details for
Bug 23258
Batch tool for placing and cancelling holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23258: fix CSRF issues
Bug-23258-fix-CSRF-issues.patch (text/plain), 2.63 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-07-16 11:41:40 UTC
(
hide
)
Description:
Bug 23258: fix CSRF issues
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-07-16 11:41:40 UTC
Size:
2.63 KB
patch
obsolete
>From dce068d8b82c15fbf7bbe57bb9ab0e8a5e93b621 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 16 Jul 2025 13:38:06 +0200 >Subject: [PATCH] Bug 23258: fix CSRF issues > >--- > circ/batch_holding.pl | 4 ++-- > .../intranet-tmpl/prog/en/modules/circ/batch_holding.tt | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/circ/batch_holding.pl b/circ/batch_holding.pl >index 900c1f0b7b..8d6c6979b4 100755 >--- a/circ/batch_holding.pl >+++ b/circ/batch_holding.pl >@@ -66,7 +66,7 @@ if ($op) { > } > } > >-if ($op eq "show"){ >+if ($op eq "cud-show"){ > my $filefh = $input->upload('uploadfile'); > my $filecontent = $input->param('filecontent'); > my $branch = $input->param('branch'); >@@ -131,7 +131,7 @@ if ($op eq "show"){ > ); > } > >-elsif ($op eq "result") { >+elsif ($op eq "cud-result") { > my $branch = $input->param('branch'); > my $action = $input->param('action'); > my @itemnumbers = $input->multi_param('holdable'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/batch_holding.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/batch_holding.tt >index e67a4a41a5..023b70c8d3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/batch_holding.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/batch_holding.tt >@@ -46,6 +46,7 @@ > [% IF (holdloop) %] > <h1>[% action %] holds on the following barcodes</h1> > <form action="batch_holding.pl" method="POST"> >+ [% INCLUDE 'csrf-token.inc' %] > <ul> > [% FOREACH hold IN holdloop %] > <li> >@@ -58,7 +59,7 @@ > </li> > [% END %] > </ul> >- <input type="hidden" name="op" value="result" /> >+ <input type="hidden" name="op" value="cud-result" /> > <input type="hidden" name="action" value="[% action %]" /> > <input type="hidden" name="branch" value="[% branch %]" /> > <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" /> >@@ -97,6 +98,7 @@ > [% ELSE %] > <h1>Batch holding</h1> > <form method="post" enctype="multipart/form-data" action="/cgi-bin/koha/circ/batch_holding.pl" id="batchholdform"> >+ [% INCLUDE 'csrf-token.inc' %] > <fieldset class="rows"> > <legend>Use a barcode file</legend> > <ol> >@@ -146,7 +148,7 @@ > </li> > </ol> > </fieldset> >- <input type="hidden" name="op" value="show" /> >+ <input type="hidden" name="op" value="cud-show" /> > <input type="submit" value="Continue" class="button" /> > </form> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23258
:
91230
|
106055
|
106077
|
106091
|
106598
|
107408
|
108498
|
108504
|
108628
|
108630
|
180199
|
180231
| 184148