Bugzilla – Attachment 184186 Details for
Bug 40171
ILL Patron Has No Email Address on File message upon "Send Notice To Patron"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40171: Add tests
Bug-40171-Add-tests.patch (text/plain), 1.30 KB, created by
Pedro Amorim
on 2025-07-17 08:33:11 UTC
(
hide
)
Description:
Bug 40171: Add tests
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-07-17 08:33:11 UTC
Size:
1.30 KB
patch
obsolete
>From 6f87286a016d2abd097d5c1fefd36321fa72c01c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 17 Jul 2025 08:32:25 +0000 >Subject: [PATCH] Bug 40171: Add tests > >prove t/db_dependent/Koha/ILL/Requests.t >--- > t/db_dependent/Koha/ILL/Requests.t | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/ILL/Requests.t b/t/db_dependent/Koha/ILL/Requests.t >index a60d099aa25..e788ef4b788 100755 >--- a/t/db_dependent/Koha/ILL/Requests.t >+++ b/t/db_dependent/Koha/ILL/Requests.t >@@ -1066,7 +1066,7 @@ subtest 'Backend core methods' => sub { > > subtest 'Helpers' => sub { > >- plan tests => 26; >+ plan tests => 27; > > $schema->storage->txn_begin; > >@@ -1365,6 +1365,14 @@ Attribute: Pages=[% illrequestattributes.pages %] > 'Koha::ILL::Request->get_notice lang correctly defaults to "default" for a request without a patron' > ); > >+ Koha::Patron::MessagePreference::Attributes->delete(); >+ my $no_message_preferences_return = $illrq_obj->send_patron_notice('ILL_PICKUP_READY'); >+ is_deeply( >+ $no_message_preferences_return, >+ { result => { fail => [ 'email', 'sms' ], success => [] } }, >+ "Correct error when patron has no message preferences" >+ ); >+ > $schema->storage->txn_rollback; > }; > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40171
:
183383
|
183384
|
183385
|
183593
|
183594
|
183595
|
183627
|
183628
|
183629
|
184157
|
184158
|
184159
| 184186