Bugzilla – Attachment 184200 Details for
Bug 40437
Koha/Installer.t generates a warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40437: Remove warning from Koha/Installer.t
Bug-40437-Remove-warning-from-KohaInstallert.patch (text/plain), 1.33 KB, created by
Jonathan Druart
on 2025-07-17 13:38:34 UTC
(
hide
)
Description:
Bug 40437: Remove warning from Koha/Installer.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-17 13:38:34 UTC
Size:
1.33 KB
patch
obsolete
>From 1766cd1ba6a05f975256ffd2feb78bd0ce028a7d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 17 Jul 2025 15:38:01 +0200 >Subject: [PATCH] Bug 40437: Remove warning from Koha/Installer.t > >t/db_dependent/Koha/Installer.t .. 1/4 Use of uninitialized value $db_version in numeric eq (==) at /kohadevbox/koha/Koha/Installer.pm line 32. >--- > Koha/Installer.pm | 2 +- > t/db_dependent/Koha/Installer.t | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/Koha/Installer.pm b/Koha/Installer.pm >index 235eac32475..48a50df2b62 100644 >--- a/Koha/Installer.pm >+++ b/Koha/Installer.pm >@@ -29,7 +29,7 @@ sub needs_update { > my $koha_version = Koha->version; > my $code_version = TransformToNum($koha_version); > >- if ( $db_version == $code_version ) { >+ if ( $db_version && $db_version == $code_version ) { > $needs_update = 0; > } > >diff --git a/t/db_dependent/Koha/Installer.t b/t/db_dependent/Koha/Installer.t >index c9091d2bde4..f127bf04526 100755 >--- a/t/db_dependent/Koha/Installer.t >+++ b/t/db_dependent/Koha/Installer.t >@@ -18,7 +18,8 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More tests => 4; >+use Test::More tests => 5; >+use Test::NoWarnings; > > use Test::MockModule; > use File::Temp qw/tempdir/; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40437
:
184200
|
184204
|
184372