Bugzilla – Attachment 184239 Details for
Bug 40421
Logged in info should be data-attributes instead and text
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40421: Make HTML elements data attributes
Bug-40421-Make-HTML-elements-data-attributes.patch (text/plain), 4.95 KB, created by
Lucas Gass (lukeg)
on 2025-07-17 17:16:50 UTC
(
hide
)
Description:
Bug 40421: Make HTML elements data attributes
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-07-17 17:16:50 UTC
Size:
4.95 KB
patch
obsolete
>From e33bc4454ca4e61bf45c76b0df71c02544c27504 Mon Sep 17 00:00:00 2001 >From: Eric Garcia <cubingguy714@gmail.com> >Date: Thu, 17 Jul 2025 17:03:13 +0000 >Subject: [PATCH] Bug 40421: Make HTML elements data attributes > >Test Plan: >1. Apply patch >2. In Staff Interface inspect element and notice HTML has data attributes > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/includes/header.inc | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >index 15e1f17ce53..16ed39f758e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >@@ -104,14 +104,16 @@ > </span> > <span id="logged-in-info-full"> > [% SET is_superlibrarian = CAN_user_superlibrarian ? 'is_superlibrarian' : '' %] >- <span class="loggedinusername [% is_superlibrarian | html %]">[% logged_in_user.userid | html %]</span> >- <span class="loggedincategorycode content_hidden">[% logged_in_user.categorycode | html %]</span> >+ <span class="loggedinusername [% is_superlibrarian | html %]" data-loggedinusername="[% logged_in_user.userid | html %]" data-is-superlibrarian="[% is_superlibrarian | html %]" >+ >[% logged_in_user.userid | html %]</span >+ > >+ <span class="loggedincategorycode content_hidden" data-loggedincategorycode="[% logged_in_user.categorycode | html %]">[% logged_in_user.categorycode | html %]</span> > [% IF ( StaffLoginRestrictLibraryByIP ) %] > <brand> [% Branches.GetLoggedInBranchname | html %] </brand> > [% ELSE %] > <strong> >- <span class="logged-in-branch-name">[% Branches.GetLoggedInBranchname | html %]</span> >- <span class="logged-in-branch-code content_hidden">[% Branches.GetLoggedInBranchcode | html %]</span> >+ <span class="logged-in-branch-name" data-logged-in-branch-name="[% Branches.GetLoggedInBranchname | html %]">[% Branches.GetLoggedInBranchname | html %]</span> >+ <span class="logged-in-branch-code content_hidden" data-logged-in-branch-code="[% Branches.GetLoggedInBranchcode | html %]">[% Branches.GetLoggedInBranchcode | html %]</span> > </strong> > [% END %] > [% IF Koha.Preference('UseCirculationDesks') && Desks.ListForLibrary.count %] >@@ -120,16 +122,16 @@ > [% IF ( Desks.GetLoggedInDeskName == '' ) %] > <span class="logged-in-desk-name">NO DESK SET</span> > [% ELSE %] >- <span class="logged-in-desk-name">[% Desks.GetLoggedInDeskName | html %]</span> >- <span class="logged-in-desk-id content_hidden">[% Desks.GetLoggedInDeskId | html %]</span> >+ <span class="logged-in-desk-name" data-logged-in-desk-name="[% Desks.GetLoggedInDeskName | html %]">[% Desks.GetLoggedInDeskName | html %]</span> >+ <span class="logged-in-desk-id content_hidden" data-logged-in-desk-id="[% Desks.GetLoggedInDeskId | html %]">[% Desks.GetLoggedInDeskId | html %]</span> > [% END %] > </strong> > [% END %] > [% IF Koha.Preference('UseCashRegisters') && !(Registers.session_register_name == '') %] > <span class="separator">|</span> > <strong> >- <span class="logged-in-register-name">[% Registers.session_register_name | html %]</span> >- <span class="logged-in-register-id content_hidden">[% Registers.session_register_id | html %]</span> >+ <span class="logged-in-register-name" data-logged-in-register-name="[% Registers.session_register_name | html %]">[% Registers.session_register_name | html %]</span> >+ <span class="logged-in-register-id content_hidden" data-logged-in-register-id="[% Registers.session_register_id | html %]">[% Registers.session_register_id | html %]</span> > </strong> > [% END %] > </span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40421
:
184237
|
184239
|
184378