Bugzilla – Attachment 184244 Details for
Bug 40376
AuthorisedValues.t generates a warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40376: Remove warning from AuthorisedValues.t
Bug-40376-Remove-warning-from-AuthorisedValuest.patch (text/plain), 1.87 KB, created by
David Nind
on 2025-07-17 22:11:21 UTC
(
hide
)
Description:
Bug 40376: Remove warning from AuthorisedValues.t
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-07-17 22:11:21 UTC
Size:
1.87 KB
patch
obsolete
>From e249ea9b43883c34cbfea1b0a65645b0488b6d1f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Jul 2025 11:56:36 +0200 >Subject: [PATCH] Bug 40376: Remove warning from AuthorisedValues.t > >t/db_dependent/AuthorisedValues.t .. 1/17 DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'tagsubfield' on MarcSubfieldStructure - perhaps you forgot to set its 'is_auto_increment' attrib >ute during add_columns()? Treating 'tagsubfield' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 174 > >It is a bit scary but it's only that we forgot to pass a value for >tagsubfield (that is NOT NULL and part of the PK) > >Signed-off-by: David Nind <david@davidnind.com> >--- > t/db_dependent/AuthorisedValues.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/AuthorisedValues.t b/t/db_dependent/AuthorisedValues.t >index cf07bfc0017..559cd2ec74a 100755 >--- a/t/db_dependent/AuthorisedValues.t >+++ b/t/db_dependent/AuthorisedValues.t >@@ -194,8 +194,8 @@ subtest 'search_by_*_field + find_by_koha_field + get_description + authorised_v > kohafield => 'items.restricted' > } > )->store; >- Koha::MarcSubfieldStructure->new( { tagfield => '003', frameworkcode => '', authorised_value => 'CONTROL_TEST', } ) >- ->store; >+ Koha::MarcSubfieldStructure->new( >+ { tagfield => '003', tagsubfield => '@', frameworkcode => '', authorised_value => 'CONTROL_TEST', } )->store; > Koha::AuthorisedValue->new( { category => 'TEST', authorised_value => 'location_1', lib => 'location_1' } )->store; > Koha::AuthorisedValue->new( { category => 'TEST', authorised_value => 'location_2', lib => 'location_2' } )->store; > Koha::AuthorisedValue->new( { category => 'TEST', authorised_value => 'location_3', lib => 'location_3' } )->store; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40376
:
184078
| 184244