Bugzilla – Attachment 184309 Details for
Bug 40380
Koha/Patrons/Import.t generates warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40380: Remove warnings from Patrons/Import.t - Use of uninitialized value $csvkeycol{"dateexpiry"} in array element
Bug-40380-Remove-warnings-from-PatronsImportt---Us.patch (text/plain), 1.86 KB, created by
Marcel de Rooy
on 2025-07-18 09:24:52 UTC
(
hide
)
Description:
Bug 40380: Remove warnings from Patrons/Import.t - Use of uninitialized value $csvkeycol{"dateexpiry"} in array element
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-07-18 09:24:52 UTC
Size:
1.86 KB
patch
obsolete
>From 118e57e2c2cb795456d280d86723086a4363223a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Jul 2025 13:43:18 +0200 >Subject: [PATCH] Bug 40380: Remove warnings from Patrons/Import.t - Use of > uninitialized value $csvkeycol{"dateexpiry"} in array element >Content-Type: text/plain; charset=utf-8 > >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$handle_2> line 2. >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$handle_3> line 2. >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$handle_4> line 2. >Use of uninitialized value $csvkeycol{"dateexpiry"} in array element at /kohadevbox/koha/Koha/Patrons/Import.pm line 310, <$fh> line 2. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Patrons/Import.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index 50c17e0153..fa3f05fc3c 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -307,7 +307,8 @@ LINE: while ( my $borrowerline = <$handle> ) { > next if $col eq 'password' && !$overwrite_passwords; > next if $col eq 'dateexpiry' && $update_dateexpiry; > >- $borrower{$col} = $member->{$col} if $col eq 'dateexpiry' && !$columns[ $csvkeycol{$col} ]; >+ $borrower{$col} = $member->{$col} >+ if $col eq 'dateexpiry' && ( !$csvkeycol{$col} || !$columns[ $csvkeycol{$col} ] ); > > unless ( exists( $csvkeycol{$col} ) || $defaults->{$col} ) { > $borrower{$col} = $member->{$col} if ( $member->{$col} ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40380
:
184082
|
184083
|
184283
|
184284
| 184309 |
184310