Bugzilla – Attachment 184321 Details for
Bug 38102
Checkout history in OPAC displaying more than 50 items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38102: Fix limit to 50 items in the checkout history - OPAC
Bug-38102-Fix-limit-to-50-items-in-the-checkout-hi.patch (text/plain), 1.65 KB, created by
Martin Renvoize (ashimema)
on 2025-07-18 10:57:33 UTC
(
hide
)
Description:
Bug 38102: Fix limit to 50 items in the checkout history - OPAC
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-18 10:57:33 UTC
Size:
1.65 KB
patch
obsolete
>From a3cf7031f7b58b18733056f0995d0274df7b5293 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 10 Jul 2025 09:51:32 +0200 >Subject: [PATCH] Bug 38102: Fix limit to 50 items in the checkout history - > OPAC > >Checkout history does not limit to 50 items, it's a regression from bug >33949. > >To limit to 50 items we need to use "rows", not "limit". > >Test plan: >Have more than 50 checkouts and confirm that by default the table only >displays 50 entries. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > opac/opac-readingrecord.pl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl >index 4fe1622bc12..5243872c734 100755 >--- a/opac/opac-readingrecord.pl >+++ b/opac/opac-readingrecord.pl >@@ -66,23 +66,23 @@ $limit //= ''; > $limit = ( $limit eq 'full' ) ? 0 : 50; > > my $checkouts = [ >- $patron->checkouts( >+ $patron->checkouts->search( > {}, > { > order_by => $order, > prefetch => { item => { biblio => 'biblioitems' } }, >- ( $limit ? ( limit => $limit ) : () ), >+ ( $limit ? ( rows => $limit ) : () ), > } > )->as_list > ]; > $limit -= scalar(@$checkouts) if $limit; > my $old_checkouts = [ >- $patron->old_checkouts( >+ $patron->old_checkouts->search( > {}, > { > order_by => $order, > prefetch => { item => { biblio => 'biblioitems' } }, >- ( $limit ? ( limit => $limit ) : () ), >+ ( $limit ? ( rows => $limit ) : () ), > } > )->as_list > ]; >-- >2.50.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38102
:
183921
|
183922
|
184206
|
184207
| 184321 |
184322