Bugzilla – Attachment 184387 Details for
Bug 40333
When EDIFACT is enabled, one should be able view the corresponding EDIFACT INVOICE message on the Koha Invoice page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40333: (follow-up) Terminology
Bug-40333-follow-up-Terminology.patch (text/plain), 4.07 KB, created by
Martin Renvoize (ashimema)
on 2025-07-18 14:23:23 UTC
(
hide
)
Description:
Bug 40333: (follow-up) Terminology
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-18 14:23:23 UTC
Size:
4.07 KB
patch
obsolete
>From 3281ddaa7d27fafe0dd67258083224a28825ee1c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 18 Jul 2025 15:18:33 +0100 >Subject: [PATCH] Bug 40333: (follow-up) Terminology > >The envelope level of EDIFACT is called an 'Interchange'. This patch >updates our UI terminology to match the official protocol terminology as >what we're actually displaying here is the Interchange file that >contains the related message for the Invoice. The interchange file will >often contain other messages of the same type that came through at the >same time of the this invoice generation. > >Sponsored-by: Open Fifth <https://openfith.co.uk> >Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> >--- > .../prog/en/includes/modals/edifact-modal.inc | 8 ++++---- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/edifact-modal.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/edifact-modal.inc >index 7886d4990c3..5be799cff53 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/edifact-modal.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/edifact-modal.inc >@@ -1,12 +1,12 @@ >-[%# EDIFACT message modal include %] >-[%# This modal can be used on any page that needs to display EDIFACT messages %] >+[%# EDIFACT interchange modal include %] >+[%# This modal can be used on any page that needs to display EDIFACT interchanges %] > >-<!-- Modal to display EDIFACT messages --> >+<!-- Modal to display EDIFACT interchanges --> > <div class="modal" id="EDI_modal" tabindex="-1" role="dialog" aria-labelledby="EDI_modal_label" aria-hidden="true"> > <div class="modal-dialog modal-lg"> > <div class="modal-content"> > <div class="modal-header"> >- <h1 class="modal-title" id="EDI_modal_label">EDIFACT message</h1> >+ <h1 class="modal-title" id="EDI_modal_label">EDIFACT Interchange</h1> > <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index 766faccdeba..9997f998e2f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -59,20 +59,20 @@ > > [% IF edifact_enabled && edifact_message %] > <div class="page-section"> >- <h3>EDIFACT Message</h3> >+ <h3>EDIFACT Interchange</h3> > <p> >- <strong>Message type:</strong> [% edifact_message.message_type | html %] <strong>Transfer date:</strong> [% edifact_message.transfer_date | $KohaDates %] <strong>Status:</strong> [% edifact_message.status | html %] >+ <strong>Interchange type:</strong> [% edifact_message.message_type | html %] <strong>Transfer date:</strong> [% edifact_message.transfer_date | $KohaDates %] <strong>Status:</strong> [% edifact_message.status | html %] > [% IF edifact_message.filename %] > <strong>Filename:</strong> [% edifact_message.filename | html %] > [% END %] > </p> > <p> >- <a href="#" class="btn btn-default btn-sm view_edifact_message" data-message-id="[% edifact_message.id | html %]"> <i class="fa fa-search"></i> View EDIFACT message </a> >+ <a href="#" class="btn btn-default btn-sm view_edifact_message" data-message-id="[% edifact_message.id | html %]"> <i class="fa fa-search"></i> View interchange</a> > </p> > > [% IF edifact_errors.size > 0 %] > <div class="alert alert-warning"> >- <h4><i class="fa fa-exclamation-triangle"></i> EDIFACT Processing Errors</h4> >+ <h4><i class="fa fa-exclamation-triangle"></i> Processing Errors</h4> > <ul> > [% FOREACH error IN edifact_errors %] > <li> >-- >2.50.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40333
:
183902
|
183903
|
183941
|
183942
|
184385
|
184386
| 184387