Bugzilla – Attachment 184388 Details for
Bug 40439
We cannot use the arrow keys to navigate through all the items in the navigation menus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40439: Enable the navigation using arrow keys
Bug-40439-Enable-the-navigation-using-arrow-keys.patch (text/plain), 6.69 KB, created by
Nina Martinez
on 2025-07-18 14:28:06 UTC
(
hide
)
Description:
Bug 40439: Enable the navigation using arrow keys
Filename:
MIME Type:
Creator:
Nina Martinez
Created:
2025-07-18 14:28:06 UTC
Size:
6.69 KB
patch
obsolete
>From 3f798d791fcfbdffa6a901d521a62f10dfcfdb54 Mon Sep 17 00:00:00 2001 >From: nina martinez <nina.martinez@biblibre.com> >Date: Tue, 15 Jul 2025 11:42:55 +0200 >Subject: [PATCH] Bug 40439: Enable the navigation using arrow keys > >Test plan: > >1- Apply the patch >2- Log in to an account >3- Navigate with the tap key through the navigation bar, go to 'Welcome,' press Enter, and navigate through the options with the arrow keys. >--- > .../opac-tmpl/bootstrap/css/src/opac.scss | 10 ++++ > .../bootstrap/en/includes/masthead.inc | 50 +++++++++++-------- > 2 files changed, 39 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index 05063f8160..8cd442e943 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -2991,4 +2991,14 @@ fieldset.brief label.show-password-toggle-label { > padding: 0; > } > >+ >+#search-history { >+ display: flex; >+ align-items: center; >+ i { >+ margin-right: 3px; >+ } >+} >+ >+ > @import "responsive"; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 0a658a05e3..2b4679520f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -129,7 +129,7 @@ > <li class="nav-item dropdown dropdown-menu-end"> > [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %] > [% IF ( loggedinusername ) %] >- <a href="/cgi-bin/koha/opac-user.pl" class="nav-link dropdown-toggle" id="user-menu" data-bs-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"> >+ <a href="/cgi-bin/koha/opac-user.pl" class="nav-link dropdown-item dropdown-toggle" id="user-menu" data-bs-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"> > <i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> > <span class="userlabel">Welcome, [% INCLUDE 'patron-title.inc' patron = logged_in_user no_html = 1 %]</span> > </a> >@@ -153,10 +153,10 @@ > [% END %] > > [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 && loggedinusername ) %] >- <div aria-labelledby="user-menu" role="menu" class="dropdown-menu dropdown-menu-end"> >+ <ul aria-labelledby="user-menu" role="menu" class="dropdown-menu dropdown-menu-end"> > <div id="loggedinuser-menu"> >- <p> >- <a class="login-link" href="/cgi-bin/koha/opac-user.pl" >+ <li> >+ <a class="login-link dropdown-item" href="/cgi-bin/koha/opac-user.pl" > ><span > class="loggedinusername" > data-borrowernumber="[% logged_in_user.borrowernumber | html %]" >@@ -165,26 +165,34 @@ > >Your account</span > ></a > > >- </p> >+ </li> > [% IF Koha.Preference( 'EnableOpacSearchHistory' ) %] >- <p> >- <a tabindex="0" role="menuitem" class="login-link" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> >- <span class="divider-vertical"></span> >- <a >- class="clearsh submit-form-link" >- href="#" >- data-method="post" >- data-action="/cgi-bin/koha/opac-search-history.pl" >- data-op="cud-delete" >- data-confirmation-msg="[% t('Are you sure you want to delete your search history?') | html %]" >- title="Delete your search history" >- ><i class="fa fa-trash-can" aria-hidden="true"></i> Clear</a >- > >- </p> >+ <li id="search-history"> >+ <div> >+ <a tabindex="0" role="menuitem" class="login-link dropdown-item" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> >+ </div> >+ <div> >+ <span class="divider-vertical"></span> >+ </div> >+ <div> >+ <a >+ class="clearsh dropdown-item submit-form-link" >+ href="#" >+ data-method="post" >+ data-action="/cgi-bin/koha/opac-search-history.pl" >+ data-op="cud-delete" >+ data-confirmation-msg="[% t('Are you sure you want to delete your search history?') | html %]" >+ title="Delete your search history" >+ ><i class="fa fa-trash-can" aria-hidden="true"></i>Clear</a >+ > >+ </div> >+ </li> > [% END %] >- <a tabindex="0" role="menuitem" class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">Log out</a> >+ <li> >+ <a tabindex="0" role="menuitem" class="logout dropdown-item" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">Log out</a> >+ </li> > </div> >- </div> >+ </ul> > [% END %] > </li> > <!-- Cookie consent button for non logged-in users --> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40439
:
184388
|
184933