Bugzilla – Attachment 184407 Details for
Bug 40417
Search_rs is re-instating deleted query parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40417: Remove 'validation' method
Bug-40417-Remove-validation-method.patch (text/plain), 1.16 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-07-18 17:32:06 UTC
(
hide
)
Description:
Bug 40417: Remove 'validation' method
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-07-18 17:32:06 UTC
Size:
1.16 KB
patch
obsolete
>From 710aa8fdbf0928bbcd649cd87b7ff0449080ccd8 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Wed, 16 Jul 2025 18:45:54 +0100 >Subject: [PATCH] Bug 40417: Remove 'validation' method > >We shouldn't use the ->validation method anymore as it isn't stable. We need to pass the params into the method accounting for any param changes made > >Test plan: >1) Apply the regression test patch and run the test >2) Test should fail >3) Apply this patch >4) Run test again >5) Test should pass > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/REST/Plugin/Objects.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/REST/Plugin/Objects.pm b/Koha/REST/Plugin/Objects.pm >index 59bede9a861..36f33cecea7 100644 >--- a/Koha/REST/Plugin/Objects.pm >+++ b/Koha/REST/Plugin/Objects.pm >@@ -156,7 +156,7 @@ controller, and thus shouldn't be called twice in it. > 'objects.search_rs' => sub { > my ( $c, $result_set, $query_fixers ) = @_; > >- my $args = $c->validation->output; >+ my $args = $c->req->params->to_hash; > my $attributes = {}; > > $query_fixers //= []; >-- >2.50.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40417
:
184155
|
184160
|
184161
|
184212
|
184213
|
184317
|
184318
|
184406
|
184407
|
184409
|
184410