Bugzilla – Attachment 184413 Details for
Bug 39502
Web Usability Accessibility Audit - Decorative Images Don't Need alt Text
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39502: (QA follow-up) Remove title attribute as well
Bug-39502-QA-follow-up-Remove-title-attribute-as-w.patch (text/plain), 10.29 KB, created by
Emily Lamancusa (emlam)
on 2025-07-18 18:42:59 UTC
(
hide
)
Description:
Bug 39502: (QA follow-up) Remove title attribute as well
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-07-18 18:42:59 UTC
Size:
10.29 KB
patch
obsolete
>From 58cec3d30af962f0984ff2e493d79f52148b00d5 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 18 Jul 2025 14:35:52 -0400 >Subject: [PATCH] Bug 39502: (QA follow-up) Remove title attribute as well > >When an element should be ignored by screen readers, it should have no >title attribute or an empty title attribute, in addition to a null alt >attribute. > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > .../tables/items/catalogue_detail.inc | 2 +- > .../prog/en/modules/catalogue/results.tt | 2 +- > .../prog/en/modules/virtualshelves/shelves.tt | 2 +- > .../en/xslt/MARC21slim2intranetResults.xsl | 20 +++++++++---------- > .../bootstrap/en/modules/opac-shelves.tt | 2 +- > 5 files changed, 14 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 7ea4270e71..fdbfec2cef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -396,7 +396,7 @@ > [% UNLESS noItemTypeImages %] > let image_location = item_type_image_locations[row.item_type_id]; > node += image_location >- ? '<img class="itemtype-image" src="%s" alt="" title="%s" /> '.format(escape_str(image_location), escape_str(item_type_description), escape_str(item_type_description)) >+ ? '<img class="itemtype-image" src="%s" alt="" /> '.format(escape_str(image_location), escape_str(item_type_description), escape_str(item_type_description)) > : ''; > [% END %] > node += '<span class="itypedesc itypetext">%s</span>'.format(escape_str(item_type_description)); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 8a703f516b..680dec13e0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -781,7 +781,7 @@ > [% END %] > <li class="[% items_loo.branchcode | html %] [% li_class | html %]"> > [% IF item_level_itypes && !noItemTypeImages && items_loo.imageurl %] >- <img class="itemtype-image" src="[% items_loo.imageurl | html %]" title="[% items_loo.description | html %]" alt="[% items_loo.description | html %]" /> >+ <img class="itemtype-image" src="[% items_loo.imageurl | html %]" alt="" /> > [% END %] > [% IF ( items_loo.branchname ) %] > [% items_loo.branchname | html %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 8853414337..05052171c4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -351,7 +351,7 @@ > [% UNLESS ( item_level_itypes ) %] > <td> > [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %] >- <img class="itemtype-image" src="[% itemsloo.imageurl | html %]" alt="" title="[% itemsloo.description | html %]" /> >+ <img class="itemtype-image" src="[% itemsloo.imageurl | html %]" alt="" /> > [% END %] > <span class="itypetext">[% itemsloo.description | html %]</span> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >index 0e7b2cccb9..b03a8c1f9d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >@@ -512,20 +512,20 @@ > <xsl:choose> > <xsl:when test="$leader7='c' or $leader7='d' or $leader7='m'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/book.png" alt="book" title="book" class="materialtype mt_icon_BK"/> Text</xsl:when> > <xsl:when test="$leader7='i' or $leader7='s'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/newspaper.png" alt="serial" title="serial" class="materialtype mt_icon_CR"/> Continuing resource</xsl:when> >- <xsl:when test="$leader7='a' or $leader7='b'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/book_open.png" alt="" title="article" class="materialtype mt_icon_AR"/> Article</xsl:when> >+ <xsl:when test="$leader7='a' or $leader7='b'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/book_open.png" alt="" class="materialtype mt_icon_AR"/> Article</xsl:when> > </xsl:choose> > </xsl:when> >- <xsl:when test="$leader6='t'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/book.png" alt="book" title="book" class="materialtype mt_icon_BK"/> Text</xsl:when> >- <xsl:when test="$leader6='o'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/report_disk.png" alt="" title="kit" class="materialtype mt_icon_MX"/> Kit</xsl:when> >- <xsl:when test="$leader6='p'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/report_disk.png" alt="" title="mixed materials" class="materialtype mt_icon_MX"/>Mixed materials</xsl:when> >- <xsl:when test="$leader6='m'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/computer_link.png" alt="" title="computer file" class="materialtype mt_icon_CF"/> Computer file</xsl:when> >- <xsl:when test="$leader6='e' or $leader6='f'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/map.png" alt="" title="map" class="materialtype mt_icon_MP"/> Map</xsl:when> >+ <xsl:when test="$leader6='t'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/book.png" alt="" class="materialtype mt_icon_BK"/> Text</xsl:when> >+ <xsl:when test="$leader6='o'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/report_disk.png" alt="" class="materialtype mt_icon_MX"/> Kit</xsl:when> >+ <xsl:when test="$leader6='p'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/report_disk.png" alt="" class="materialtype mt_icon_MX"/>Mixed materials</xsl:when> >+ <xsl:when test="$leader6='m'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/computer_link.png" alt="" class="materialtype mt_icon_CF"/> Computer file</xsl:when> >+ <xsl:when test="$leader6='e' or $leader6='f'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/map.png" alt="" class="materialtype mt_icon_MP"/> Map</xsl:when> > <xsl:when test="$leader6='g'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/film.png" alt="" class="materialtype mt_icon_VM"/> Film</xsl:when> > <xsl:when test="$leader6='k'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/picture.png" alt="" class="materialtype mt_icon_GR"/> Picture</xsl:when> >- <xsl:when test="$leader6='r'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/object.png" alt="" title="Object" class="materialtype mt_icon_OB"/> Object</xsl:when> >- <xsl:when test="$leader6='c' or $leader6='d'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/music.png" alt="" title="score" class="materialtype mt_icon_PR"/> Score</xsl:when> >- <xsl:when test="$leader6='i'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/sound.png" alt="" title="sound" class="materialtype mt_icon_MU"/> Sound</xsl:when> >- <xsl:when test="$leader6='j'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/sound.png" alt="" title="music" class="materialtype mt_icon_MU"/> Music</xsl:when> >+ <xsl:when test="$leader6='r'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/object.png" alt="" class="materialtype mt_icon_OB"/> Object</xsl:when> >+ <xsl:when test="$leader6='c' or $leader6='d'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/music.png" alt="" class="materialtype mt_icon_PR"/> Score</xsl:when> >+ <xsl:when test="$leader6='i'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/sound.png" alt="" class="materialtype mt_icon_MU"/> Sound</xsl:when> >+ <xsl:when test="$leader6='j'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/sound.png" alt="" class="materialtype mt_icon_MU"/> Music</xsl:when> > </xsl:choose> > </span> > </xsl:if> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index e7534fcc87..875a88da23 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -401,7 +401,7 @@ > [% UNLESS ( item_level_itypes ) %] > <td> > [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %] >- <img class="itemtype-image" src="[% itemsloo.imageurl | html %]" alt="" title="[% itemsloo.description | html %]" /> >+ <img class="itemtype-image" src="[% itemsloo.imageurl | html %]" alt="" /> > [% END %] > <span class="itypetext">[% itemsloo.description | html %]</span> > </td> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39502
:
181843
|
182548
|
182690
|
184412
| 184413